Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more vagrant hosts for multitarget testing #106

Merged
merged 1 commit into from
May 4, 2018

Conversation

marcparadise
Copy link
Member

This adds some Ubuntu hosts, and assigns consistent ssh ports & ips

Signed-off-by: Marc A. Paradise marc.paradise@gmail.com

@marcparadise marcparadise requested a review from a team May 4, 2018 17:34
jonsmorrow
jonsmorrow previously approved these changes May 4, 2018
@@ -1,10 +1,10 @@
Vagrant.configure("2") do |config|
config.ssh.forward_agent = true

config.vm.define "ubuntu1" do |node|
def ubuntu_xenial_definition(node, name, final_octet, ssh_port)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool I didn't know you could do this!

tyler-ball
tyler-ball previously approved these changes May 4, 2018
Copy link
Contributor

@tyler-ball tyler-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
@tyler-ball tyler-ball dismissed stale reviews from jonsmorrow and themself via f9b9867 May 4, 2018 17:51
@tyler-ball tyler-ball merged commit d42a49a into master May 4, 2018
@tyler-ball tyler-ball deleted the mp/moar-vagrant-hosts branch May 4, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants