add support for client_key_contents

[Tyrael]

Description

adds support for chef-vault to use the private key from the client_key_contents chef configuration option

Related Issue

#401

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[Tyrael]

bump

[Tyrael]

any feedback would be appreciated to move this forward, I'm using this patch locally without an issue for a month now, would be nice having it merged
cc @sanjain-progress @kasif-adnan @jeremiahsnapp

[Tyrael]

bump

[Tyrael]

hello, any update on this?

please let me know if there is anything needed from my side to move ahead with merging this.

[vkarve-chef]

Hi @Tyrael, thanks for creating the PR. We have marked the review/merge in our task queue. If possible, could you please add a test for this change?
our apologies on not getting to it sooner 🙏

[Tyrael]

sure, would the following two test scenarios be enough:

• if client_key_contents is set and client_key is not then client_key_contents should be used
• if client_key_contents is set and client_key is also set then client_key_contents should be used

[Tyrael]

hi @vkarve-chef,
sorry for the delay, I've just pushed the test related changes(some rspec, some cucumber/aruba), let me know if they look good to you or if there is anything else needed to move this PR forward

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[Tyrael]

I can see that this also present in the v4.1.11 tag but I can't see that tag on https://rubygems.org/gems/chef-vault/versions/
is that normal/expected?

[Tyrael]

nevermind, I can see the "Changes not yet released to rubygems.org" part in the Changelog, so this was intentional