Allow Whitespace Characters as Vault Content #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disallowing line breaks (and possibly tabs) renders Chef Vaults unusable for X.509 and SSH keys (see chef#370). This commit include these character in the set of allowed characters. Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
|
@tas50 is there any chance to get this merged? Not being able to store SSL/SSH Keys in vault makes it almost useless. |
|
addressed through #367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to use line breaks
\nand tabs\tas characters in the content of a vault.Description
Disallowing line breaks (and possibly tabs) renders Chef Vaults unusable for X.509 and SSH keys. This commit include these character in the set of allowed characters.
Please keep in mind this change only makes SSH and X.509 keys to work again. There are some cases where it is convenient to store binary data in vaults. Think of PKCS#12 files, Kerberos Keytabs, or unarmored OpenPGP keys for example. Given that it would be worth questioning the changes of #347, which introduced this changes behaviour.
Related Issue
Types of changes
Checklist: