Fixed knife vault show -F json and knife vault list -F json don't always output valid JSON #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sanga17 <sausekar@msystechnologies.com>
Signed-off-by: sanga17 <sausekar@msystechnologies.com>
sanga1794
changed the title
tas50
reviewed
Jul 29, 2020
| @@ -35,7 +35,7 @@ def run | |||
| bags.each_key do |bagname| | |||
| vaultbags.push(bagname) if bag_is_vault?(bagname) | |||
| end | |||
| output vaultbags.join("\n") | |||
There was a problem hiding this comment.
Isn't this going to result in hard to read output on the CLI?
There was a problem hiding this comment.
Hi @tas50, nothing impacted on the CLI's output, but if we use join it is causing issues for JSON format, as posted in the issue.
tas50
reviewed
Aug 18, 2020
| split_vault_keys(bag)[1].each do |item| | ||
| output item | ||
| end | ||
| output split_vault_keys(bag)[1] |
There was a problem hiding this comment.
If there's more than 1 key this will only show a single key. Is that intentional?
There was a problem hiding this comment.
Hi @tas50,yes it is intentional as split_vault_keys method return array of keys and items
chef-vault/lib/chef/knife/vault_base.rb
Line 81 in 9e9d28e
And regarding the change made in PR, below are some o/ps before change and after change:
Before Change:
knife vault show val_passwords
root
root1
knife vault show val_passwords -F json
"root"
"root1"
knife vault show val_passwords -F yaml
--- root
...
--- root1
...
After Change:
knife vault show val_passwords
root
root1
knife vault show val_passwords -F json
[
"root",
"root1"
]
knife vault show val_passwords -F yaml
---
- root
- root1
tas50
suggested changes
Aug 18, 2020
lamont-granquist
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed knife vault show -F json and knife vault list -F json don't always output valid JSON
Related Issue
Fixed: #313
Types of changes
Checklist: