Send a better error message when an invalid SSL key is encountered when creating a vault item #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkGibbons
force-pushed
the
Invalid_SSL_error
branch
from
e3c3a49
to
1079c08
Compare
…en creating a vault item When creating a vault item we get an OpenSSL::PKey::RSAError error when the user or client keys were generated from a version of chef-server before chef-server 12. The error raised has no useful information for solving the problem. Pre chef-server 12 public keys are certificates instead of public keys. This change identifies the user or client with an invalid public key. The key needs to be recreated, any existing vault items used by the server need to be refreshed after the key is generated. Signed-off-by: markgibbons <mark.gibbons@nordstrom.com>
MarkGibbons
force-pushed
the
Invalid_SSL_error
branch
from
1079c08
to
b25230f
Compare
tas50
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a vault item we get an OpenSSL::PKey::RSAError error when the user or client
keys were generated from a version of chef-server before chef-server 12. The error raised
has no useful information for solving the problem. Pre chef-server 12
public keys are certificates instead of public keys. This change identifies the
user or client with an invalid public key. The key needs to be recreated, any existing
vault items used by the server need to be refreshed after the key is generated.
Description
Creates an error message that can be used.
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List