Reduce the search response limit from 100k to 10k #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default index.max_result_window for Elasticsearch is 10k. This leads to errors like: 2017-05-03_19:36:41.82788 Caused by: QueryPhaseExecutionException[Result window is too large, from + size must be less than or equal to: [10000] but was [100000]. See the scroll api for a more efficient way to request large data sets. This limit can be set by changing the [index.max_result_window] index level parameter.] Signed-off-by: Bryan McLellan <btm@loftninjas.org>
|
do we need to do pagination then? or is that built into the search API now? |
|
i think yes, because you're passing a block and you hit the recursion in this logic? https://github.com/chef/chef/blob/master/lib/chef/search/query.rb#L76-L98 |
lamont-granquist
approved these changes
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default index.max_result_window for Elasticsearch is 10k. This leads to errors like:
2017-05-03_19:36:41.82788 Caused by: QueryPhaseExecutionException[Result window is too large, from + size must be less than or equal to: [10000] but was [100000]. See the scroll api for a more efficient way to request large data sets. This limit can be set by changing the [index.max_result_window] index level parameter.]
Signed-off-by: Bryan McLellan btm@loftninjas.org