Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace edit_data() with edit_hash() in vault_edit.rb #274

Merged
merged 1 commit into from
Apr 28, 2017

Conversation

tmaczukin
Copy link
Contributor

Fixes #273

@thommay
Copy link
Contributor

thommay commented Apr 28, 2017

Looks great. Please add a DCO signoff to your commit ( git commit -s --amend, followed by git push -f) and then we'll get this merged.

Signed-off-by: Tomasz Maczukin <tomasz@maczukin.pl>
@tmaczukin
Copy link
Contributor Author

@thommay Done! :)

@thommay thommay merged commit f67b1a7 into chef:master Apr 28, 2017
@thommay
Copy link
Contributor

thommay commented Apr 28, 2017

Awesome, merged! Thanks again

@tmaczukin tmaczukin deleted the fix-vault-edit branch April 28, 2017 11:12
@thommay thommay added the Type: Bug Does not work as expected. label Jun 7, 2017
neclimdul added a commit to neclimdul/chef-vault that referenced this pull request Jun 16, 2017
Similar to chefGH-274, replaces the usage of edit_data with edit_hash to fix
errors in chef 13 and warnings in chef 12.
neclimdul added a commit to neclimdul/chef-vault that referenced this pull request Jun 16, 2017
Similar to chefGH-274, replaces the usage of edit_data with edit_hash to fix
errors in chef 13 and warnings in chef 12.

Signed-off-by: James Gilliland <neclimdul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Does not work as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants