Make sure sparse mode is used on secrets where it is explicit #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sparse mode is marked in xxx_keys item with: > mode: "sparse" but when decrypting secrets, each node is trying to read the sparse format first (xxx_key_[node]) and then fallback to normal xxx_keys. This adds a performance penalty both on reading secrets and during refresh. With this patch, sparse format is checked only when secret is marked as sparse. This makes refresh a fast no-op (it was already a no-op with chef#269 now it is faster) since the only cost is now searching nodes matching search_query. Change-Id: I38f511b9f590240775085a386b387c476d3a1f5c Signed-off-by: Grégoire Seux <g.seux@criteo.com>
|
For reference, performance penalty during refresh is a few milliseconds per node (~40ms on my test).
with this patch, refresh operation is ~9s. |
thommay
approved these changes
May 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sparse mode is marked in xxx_keys item with:
but when decrypting secrets, each node is trying to read the sparse format first
(xxx_key_[node]) and then fallback to normal xxx_keys.
This adds a performance penalty both on reading secrets and during refresh.
With this patch, sparse format is checked only when secret is marked as sparse.
This makes refresh a fast no-op (it was already a no-op with
#269 now it is faster) since the only
cost is now searching nodes matching search_query.