Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential github action smells #3826

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

ceddy4395
Copy link
Contributor

Hey! 🙂
I've made the following changes to your workflow:

  • Avoid running CI related actions when no source code has changed
    • Running workflows which build or test certain parts of the code base without these parts being changed is useless, as nothing new will be checked or created.
  • Steps should only perform a single command
    • When one step does multiple things at once, it becomes unclear what exactly has failed during the execution of the step.
  • Avoid deploying jobs on forks
    • Deploying from a fork is usually not wanted because in that case unreviewed code by external authors will be published/deployed to main. Furthermore, forks usually don't have the correct rights to publish/deploy and will fail the workflow anyway.

I've fixed these smells in (part of) your workflows, and I'm interested in your feedback on the following changes.

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

@fb55
Copy link
Member

fb55 commented May 27, 2024

Hi @ceddy4395, thanks for this awesome PR! Prettier is currently unhappy with the formatting of a file, happy to merge once that's resolved.

- Avoid running CI related actions when no source code has changed
- Steps should only perform a single command
- Avoid deploying jobs on forks
@ceddy4395
Copy link
Contributor Author

Hi @fb55, thank you for looking at it!
Sorry for missing the failing linter, this has been resolved now :)

@fb55 fb55 merged commit a6dc56d into cheeriojs:main May 28, 2024
9 checks passed
@fb55
Copy link
Member

fb55 commented May 28, 2024

@ceddy4395 Thanks a lot, merged!

renovate bot added a commit to tomacheese/telcheck that referenced this pull request Aug 10, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [cheerio](https://cheerio.js.org/)
([source](https://togithub.com/cheeriojs/cheerio)) | [`1.0.0-rc.12` ->
`1.0.0`](https://renovatebot.com/diffs/npm/cheerio/1.0.0-rc.12/1.0.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/cheerio/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/cheerio/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/cheerio/1.0.0-rc.12/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/cheerio/1.0.0-rc.12/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>cheeriojs/cheerio (cheerio)</summary>

###
[`v1.0.0`](https://togithub.com/cheeriojs/cheerio/releases/tag/v1.0.0)

[Compare
Source](https://togithub.com/cheeriojs/cheerio/compare/v1.0.0-rc.12...v1.0.0)

Cheerio 1.0 is here! 🎉

### [Announcement Blog Post](https://cheerio.js.org/blog/cheerio-1.0)

#### Breaking Changes

- The minimum NodeJS version is now 18.17 or higher
[cheeriojs/cheerio#3959

- Import paths were simplified. For example, use `cheerio/slim` instead
of
`cheerio/lib/slim`.
[cheeriojs/cheerio#3970

- The deprecated default Cheerio instance and static methods were
removed.
[cheeriojs/cheerio#3974

    Before, it was possible to write code like this:

    ```ts
    import cheerio, { html } from 'cheerio';

html(cheerio('<test></test>')); // ~ '<test></test>' -- NO LONGER WORKS
    ```

    Make sure to always load documents first:

    ```ts
    import * as cheerio from 'cheerio';

    cheerio.load('<test></test>').html();
    ```

- Node types previously re-exported by Cheerio must now be imported
directly
from (`domhandler`)(https://github.com/fb55/domhandler).
[cheeriojs/cheerio#3969

- htmlparser2 options now reside exclusively under the `xml` key
([cheeriojs/cheerio#2916):

    ```ts
    const $ = cheerio.load('<html>', {
      xml: {
        withStartIndices: true,
      },
    });
    ```

#### New Features

- Add functions to load buffers, streams & URLs in NodeJS by
[@&#8203;fb55](https://togithub.com/fb55) in
[cheeriojs/cheerio#2857
- Add extract method by [@&#8203;fb55](https://togithub.com/fb55) in
[cheeriojs/cheerio#2750

#### Fixes

- Allow imports of `cheerio/utils` by
[@&#8203;blixt](https://togithub.com/blixt) in
[cheeriojs/cheerio#2601
- Allow empty string in `data`, and simplify by
[@&#8203;fb55](https://togithub.com/fb55) in
[cheeriojs/cheerio#2818
- Make `closest` be able to start from text nodes by
[@&#8203;Qualtagh](https://togithub.com/Qualtagh) in
[cheeriojs/cheerio#2811
- Fix potential github action smells by
[@&#8203;ceddy4395](https://togithub.com/ceddy4395) in
[cheeriojs/cheerio#3826

#### Other

- Cheerio has [a new website](https://cheerio.js.org), featuring updated
API docs and guides!
[cheeriojs/cheerio#2950

**Full Changelog**:
cheeriojs/cheerio@v1.0.0-rc.12...v1.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kodiakhq bot pushed a commit to X-oss-byte/Canary-nextjs that referenced this pull request Aug 11, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [cheerio](https://cheerio.js.org/) ([source](https://togithub.com/cheeriojs/cheerio)) | [`1.0.0-rc.12` -> `1.0.0`](https://renovatebot.com/diffs/npm/cheerio/1.0.0-rc.12/1.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/cheerio/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/cheerio/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/cheerio/1.0.0-rc.12/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/cheerio/1.0.0-rc.12/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>cheeriojs/cheerio (cheerio)</summary>

### [`v1.0.0`](https://togithub.com/cheeriojs/cheerio/releases/tag/v1.0.0)

[Compare Source](https://togithub.com/cheeriojs/cheerio/compare/v1.0.0-rc.12...v1.0.0)

Cheerio 1.0 is here! 🎉

### [Announcement Blog Post](https://cheerio.js.org/blog/cheerio-1.0)

#### Breaking Changes

-   The minimum NodeJS version is now 18.17 or higher [cheeriojs/cheerio#3959

-   Import paths were simplified. For example, use `cheerio/slim` instead of
    `cheerio/lib/slim`. [cheeriojs/cheerio#3970

-   The deprecated default Cheerio instance and static methods were removed. [cheeriojs/cheerio#3974

    Before, it was possible to write code like this:

    ```ts
    import cheerio, { html } from 'cheerio';

    html(cheerio('<test></test>')); // ~ '<test></test>' -- NO LONGER WORKS
    ```

    Make sure to always load documents first:

    ```ts
    import * as cheerio from 'cheerio';

    cheerio.load('<test></test>').html();
    ```

-   Node types previously re-exported by Cheerio must now be imported directly
    from (`domhandler`)(https://github.com/fb55/domhandler). [cheeriojs/cheerio#3969

-   htmlparser2 options now reside exclusively under the `xml` key ([cheeriojs/cheerio#2916):

    ```ts
    const $ = cheerio.load('<html>', {
      xml: {
        withStartIndices: true,
      },
    });
    ```

#### New Features

-   Add functions to load buffers, streams & URLs in NodeJS by [@&#8203;fb55](https://togithub.com/fb55) in [cheeriojs/cheerio#2857
-   Add extract method by [@&#8203;fb55](https://togithub.com/fb55) in [cheeriojs/cheerio#2750

#### Fixes

-   Allow imports of `cheerio/utils` by [@&#8203;blixt](https://togithub.com/blixt) in [cheeriojs/cheerio#2601
-   Allow empty string in `data`, and simplify by [@&#8203;fb55](https://togithub.com/fb55) in [cheeriojs/cheerio#2818
-   Make `closest` be able to start from text nodes by [@&#8203;Qualtagh](https://togithub.com/Qualtagh) in [cheeriojs/cheerio#2811
-   Fix potential github action smells by [@&#8203;ceddy4395](https://togithub.com/ceddy4395) in [cheeriojs/cheerio#3826

#### Other

-   Cheerio has [a new website](https://cheerio.js.org), featuring updated API docs and guides! [cheeriojs/cheerio#2950

**Full Changelog**: cheeriojs/cheerio@v1.0.0-rc.12...v1.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
kodiakhq bot pushed a commit to X-oss-byte/Nextjs that referenced this pull request Aug 12, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [cheerio](https://cheerio.js.org/) ([source](https://togithub.com/cheeriojs/cheerio)) | [`1.0.0-rc.12` -> `1.0.0`](https://renovatebot.com/diffs/npm/cheerio/1.0.0-rc.12/1.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/cheerio/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/cheerio/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/cheerio/1.0.0-rc.12/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/cheerio/1.0.0-rc.12/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [cheerio](https://cheerio.js.org/) ([source](https://togithub.com/cheeriojs/cheerio)) | [`0.22.0` -> `1.0.0`](https://renovatebot.com/diffs/npm/cheerio/0.22.0/1.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/cheerio/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/cheerio/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/cheerio/0.22.0/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/cheerio/0.22.0/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>cheeriojs/cheerio (cheerio)</summary>

### [`v1.0.0`](https://togithub.com/cheeriojs/cheerio/releases/tag/v1.0.0)

[Compare Source](https://togithub.com/cheeriojs/cheerio/compare/v1.0.0-rc.12...v1.0.0)

Cheerio 1.0 is here! 🎉

### [Announcement Blog Post](https://cheerio.js.org/blog/cheerio-1.0)

#### Breaking Changes

-   The minimum NodeJS version is now 18.17 or higher [cheeriojs/cheerio#3959

-   Import paths were simplified. For example, use `cheerio/slim` instead of
    `cheerio/lib/slim`. [cheeriojs/cheerio#3970

-   The deprecated default Cheerio instance and static methods were removed. [cheeriojs/cheerio#3974

    Before, it was possible to write code like this:

    ```ts
    import cheerio, { html } from 'cheerio';

    html(cheerio('<test></test>')); // ~ '<test></test>' -- NO LONGER WORKS
    ```

    Make sure to always load documents first:

    ```ts
    import * as cheerio from 'cheerio';

    cheerio.load('<test></test>').html();
    ```

-   Node types previously re-exported by Cheerio must now be imported directly
    from (`domhandler`)(https://github.com/fb55/domhandler). [cheeriojs/cheerio#3969

-   htmlparser2 options now reside exclusively under the `xml` key ([cheeriojs/cheerio#2916):

    ```ts
    const $ = cheerio.load('<html>', {
      xml: {
        withStartIndices: true,
      },
    });
    ```

#### New Features

-   Add functions to load buffers, streams & URLs in NodeJS by [@&#8203;fb55](https://togithub.com/fb55) in [cheeriojs/cheerio#2857
-   Add extract method by [@&#8203;fb55](https://togithub.com/fb55) in [cheeriojs/cheerio#2750

#### Fixes

-   Allow imports of `cheerio/utils` by [@&#8203;blixt](https://togithub.com/blixt) in [cheeriojs/cheerio#2601
-   Allow empty string in `data`, and simplify by [@&#8203;fb55](https://togithub.com/fb55) in [cheeriojs/cheerio#2818
-   Make `closest` be able to start from text nodes by [@&#8203;Qualtagh](https://togithub.com/Qualtagh) in [cheeriojs/cheerio#2811
-   Fix potential github action smells by [@&#8203;ceddy4395](https://togithub.com/ceddy4395) in [cheeriojs/cheerio#3826

#### Other

-   Cheerio has [a new website](https://cheerio.js.org), featuring updated API docs and guides! [cheeriojs/cheerio#2950

**Full Changelog**: cheeriojs/cheerio@v1.0.0-rc.12...v1.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/X-oss-byte/Nextjs).
renovate bot added a commit to redwoodjs/redwood that referenced this pull request Aug 12, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [cheerio](https://cheerio.js.org/)
([source](https://togithub.com/cheeriojs/cheerio)) | [`1.0.0-rc.12` ->
`1.0.0`](https://renovatebot.com/diffs/npm/cheerio/1.0.0-rc.12/1.0.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/cheerio/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/cheerio/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/cheerio/1.0.0-rc.12/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/cheerio/1.0.0-rc.12/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>cheeriojs/cheerio (cheerio)</summary>

###
[`v1.0.0`](https://togithub.com/cheeriojs/cheerio/releases/tag/v1.0.0)

[Compare
Source](https://togithub.com/cheeriojs/cheerio/compare/v1.0.0-rc.12...v1.0.0)

Cheerio 1.0 is here! 🎉

### [Announcement Blog Post](https://cheerio.js.org/blog/cheerio-1.0)

#### Breaking Changes

- The minimum NodeJS version is now 18.17 or higher
[cheeriojs/cheerio#3959

- Import paths were simplified. For example, use `cheerio/slim` instead
of
`cheerio/lib/slim`.
[cheeriojs/cheerio#3970

- The deprecated default Cheerio instance and static methods were
removed.
[cheeriojs/cheerio#3974

    Before, it was possible to write code like this:

    ```ts
    import cheerio, { html } from 'cheerio';

html(cheerio('<test></test>')); // ~ '<test></test>' -- NO LONGER WORKS
    ```

    Make sure to always load documents first:

    ```ts
    import * as cheerio from 'cheerio';

    cheerio.load('<test></test>').html();
    ```

- Node types previously re-exported by Cheerio must now be imported
directly
from (`domhandler`)(https://github.com/fb55/domhandler).
[cheeriojs/cheerio#3969

- htmlparser2 options now reside exclusively under the `xml` key
([cheeriojs/cheerio#2916):

    ```ts
    const $ = cheerio.load('<html>', {
      xml: {
        withStartIndices: true,
      },
    });
    ```

#### New Features

- Add functions to load buffers, streams & URLs in NodeJS by
[@&#8203;fb55](https://togithub.com/fb55) in
[cheeriojs/cheerio#2857
- Add extract method by [@&#8203;fb55](https://togithub.com/fb55) in
[cheeriojs/cheerio#2750

#### Fixes

- Allow imports of `cheerio/utils` by
[@&#8203;blixt](https://togithub.com/blixt) in
[cheeriojs/cheerio#2601
- Allow empty string in `data`, and simplify by
[@&#8203;fb55](https://togithub.com/fb55) in
[cheeriojs/cheerio#2818
- Make `closest` be able to start from text nodes by
[@&#8203;Qualtagh](https://togithub.com/Qualtagh) in
[cheeriojs/cheerio#2811
- Fix potential github action smells by
[@&#8203;ceddy4395](https://togithub.com/ceddy4395) in
[cheeriojs/cheerio#3826

#### Other

- Cheerio has [a new website](https://cheerio.js.org), featuring updated
API docs and guides!
[cheeriojs/cheerio#2950

**Full Changelog**:
cheeriojs/cheerio@v1.0.0-rc.12...v1.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
benelan added a commit to Esri/calcite-design-system that referenced this pull request Aug 16, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [cheerio](https://cheerio.js.org/)
([source](https://togithub.com/cheeriojs/cheerio)) | [`1.0.0-rc.12` ->
`1.0.0`](https://renovatebot.com/diffs/npm/cheerio/1.0.0-rc.12/1.0.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/cheerio/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/cheerio/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/cheerio/1.0.0-rc.12/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/cheerio/1.0.0-rc.12/1.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>cheeriojs/cheerio (cheerio)</summary>

###
[`v1.0.0`](https://togithub.com/cheeriojs/cheerio/releases/tag/v1.0.0)

[Compare
Source](https://togithub.com/cheeriojs/cheerio/compare/v1.0.0-rc.12...v1.0.0)

Cheerio 1.0 is here! 🎉

### [Announcement Blog Post](https://cheerio.js.org/blog/cheerio-1.0)

#### Breaking Changes

- The minimum NodeJS version is now 18.17 or higher
[cheeriojs/cheerio#3959

- Import paths were simplified. For example, use `cheerio/slim` instead
of
`cheerio/lib/slim`.
[cheeriojs/cheerio#3970

- The deprecated default Cheerio instance and static methods were
removed.
[cheeriojs/cheerio#3974

    Before, it was possible to write code like this:

    ```ts
    import cheerio, { html } from 'cheerio';

html(cheerio('<test></test>')); // ~ '<test></test>' -- NO LONGER WORKS
    ```

    Make sure to always load documents first:

    ```ts
    import * as cheerio from 'cheerio';

    cheerio.load('<test></test>').html();
    ```

- Node types previously re-exported by Cheerio must now be imported
directly
from (`domhandler`)(https://github.com/fb55/domhandler).
[cheeriojs/cheerio#3969

- htmlparser2 options now reside exclusively under the `xml` key
([cheeriojs/cheerio#2916):

    ```ts
    const $ = cheerio.load('<html>', {
      xml: {
        withStartIndices: true,
      },
    });
    ```

#### New Features

- Add functions to load buffers, streams & URLs in NodeJS by
[@&#8203;fb55](https://togithub.com/fb55) in
[cheeriojs/cheerio#2857
- Add extract method by [@&#8203;fb55](https://togithub.com/fb55) in
[cheeriojs/cheerio#2750

#### Fixes

- Allow imports of `cheerio/utils` by
[@&#8203;blixt](https://togithub.com/blixt) in
[cheeriojs/cheerio#2601
- Allow empty string in `data`, and simplify by
[@&#8203;fb55](https://togithub.com/fb55) in
[cheeriojs/cheerio#2818
- Make `closest` be able to start from text nodes by
[@&#8203;Qualtagh](https://togithub.com/Qualtagh) in
[cheeriojs/cheerio#2811
- Fix potential github action smells by
[@&#8203;ceddy4395](https://togithub.com/ceddy4395) in
[cheeriojs/cheerio#3826

#### Other

- Cheerio has [a new website](https://cheerio.js.org), featuring updated
API docs and guides!
[cheeriojs/cheerio#2950

**Full Changelog**:
cheeriojs/cheerio@v1.0.0-rc.12...v1.0.0

</details>

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6ImRldiIsImxhYmVscyI6WyJjaG9yZSIsImRlcGVuZGVuY2llcyJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <no-reply@benelan.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants