Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Rails common error reporter #7

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Conversation

skatkov
Copy link
Collaborator

@skatkov skatkov commented Jun 5, 2024

fixes #2

Most error monitoring software claim support for Rails.error.handle, but no support for Rails.error.recordapproach. But .handle method swallows errors and that makes it's usage complicated in our case.

In this PR I suggest usage of Rails.error.report, this method is used underneath of Rails.error.handle, so should be as well supported by most error monitoring services and it fits perfectly to our use case.

If we merge thos feature, this gem will be feature complete for usage in Cheddar's monolith application.

Relevant documentation:

@skatkov skatkov requested a review from julik June 5, 2024 22:50
@skatkov skatkov changed the title Introduce Rails common error handler Introduce Rails common error reporter Jun 5, 2024
@skatkov skatkov merged commit 4e41595 into main Jun 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce configurable error handling
2 participants