Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Maven plugins #118

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Conversation

Bananeweizen
Copy link
Collaborator

Update all the Maven plugins which have a fixed version. To simplify the
check for Maven updates in the future, a new shared launch config for
Eclipse has been added.

Still, some standard Maven plugins (and Maven itself) are not versioned,
which can lead to different build results, and should be changed.

Update all the Maven plugins which have a fixed version. To simplify the
check for Maven updates in the future, a new shared launch config for
Eclipse has been added.

Still, some standard Maven plugins (and Maven itself) are not versioned,
which can lead to different build results, and should be changed.
@romani
Copy link
Member

romani commented Dec 27, 2018

I never used maven version updates from Eclipse UI.

But why not simply use maven standard plugin for controlling this ?

example: https://github.com/checkstyle/checkstyle/blob/master/config/version-number-rules.xml
We run it as: https://github.com/checkstyle/checkstyle/blob/master/.ci/travis/travis.sh#L97
Result: https://travis-ci.org/checkstyle/checkstyle/jobs/472422393#L2843

@lkoe lkoe merged commit 353a44f into checkstyle:master Dec 27, 2018
@Bananeweizen
Copy link
Collaborator Author

But why not simply use maven standard plugin for controlling this ?

The new launch config does nothing more than running "versions:dependency-updates versions:plugin-updates" from eclipse, so it is exactly the same as you running this from a wrapper shell script. The launch config is only meant to help developers that they don't need to remember the syntax (I tend to forget it, too).

example: https://github.com/checkstyle/checkstyle/blob/master/config/version-number-rules.xml

Version plugin rules are deprecated. See the plugin documentation.

@Bananeweizen Bananeweizen deleted the updateMavenPlugins branch December 28, 2018 10:16
@romani
Copy link
Member

romani commented Dec 28, 2018

It will stay :) as it awesome functionality, it is marked as deprecated by mistake.

https://www.mojohaus.org/versions-maven-plugin/version-rules.html
mojohaus/versions#157 (comment)

The launch config is only meant to help developers that they don't need to remember the syntax (I tend to forget it, too).

CI script should know all and remind you what to update.
In library project we always do update for each version in separate commit, as unfortunate changes in new versions and crazy side effects happening frequently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants