Support for Java 14 switch/yield expression #6615

krzyk · 2019-03-27T10:02:35Z

Running checkstyle validation on a class that contains switch expression:

        return switch (c.getLocation().toLowerCase()) {                                                                                                                                                                      
            case "query" -> String.format("ARGS_GET:%s", c.getFullPath().get(0));
            case "header" -> String.format("REQUEST_HEADERS:%s", c.getFullPath().get(0));
            case "cookie" -> String.format("REQUEST_COOKIES:%s", c.getFullPath().get(0));
            default -> "";                                                      
        };

fails with:

unexpected token: switch

And also

expecting EOF, found 'case'

FIX Summary:
new Tokens are created. Syntax should be supported, Checks will be updated later on, See follow up issues.
see #8449 for more details

The text was updated successfully, but these errors were encountered:

rnveach · 2019-03-27T11:24:07Z

Examples and explanation: https://openjdk.java.net/jeps/325

OpenJDK repositories:
https://hg.openjdk.java.net/jdk-updates/jdk11u/
https://hg.openjdk.java.net/jdk-updates/jdk12u/

igorleal · 2019-04-02T09:41:00Z

Some more info from when executing checkstyle:

Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: IllegalStateException occurred while parsing file [myfile.java].
    at com.puppycrawl.tools.checkstyle.JavaParser.parse (JavaParser.java:103)
    at com.puppycrawl.tools.checkstyle.TreeWalker.processFiltered (TreeWalker.java:160)
    at com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck.process (AbstractFileSetCheck.java:85)
    at com.puppycrawl.tools.checkstyle.Checker.processFile (Checker.java:332)
    at com.puppycrawl.tools.checkstyle.Checker.processFiles (Checker.java:294)
    at com.puppycrawl.tools.checkstyle.Checker.process (Checker.java:220)
    at org.apache.maven.plugins.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle (DefaultCheckstyleExecutor.java:248)
    at org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.executeReport (AbstractCheckstyleReport.java:463)
    at org.apache.maven.plugins.checkstyle.CheckstyleReport.executeReport (CheckstyleReport.java:57)
    at org.apache.maven.reporting.AbstractMavenReport.generate (AbstractMavenReport.java:255)
    at org.apache.maven.reporting.AbstractMavenReport.execute (AbstractMavenReport.java:143)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:567)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356)

romani · 2019-08-04T00:59:26Z

There some work is done, but not completed, everyone is welcome to continue, referenced code can be reused.

koppor · 2020-03-30T14:09:53Z

Updated JEP: JEP-361. Included in JDK 14.

(Thus closing out #7992)

koppor · 2020-04-08T04:24:35Z

For the ones feeling blocked, by checkstyle excpetions on java 14 files, see https://stackoverflow.com/a/61071633/873282:

You must use https://checkstyle.org/config_filefilters.html#BeforeExecutionExclusionFileFilter in your Checkstyle config to tell Checkstyle to not process these files at all

This includes allowing switch as an expression, i.e. switch expressions, and allowing mutliple expressions in both labels and rules as according to the JLS.

octylFractal · 2020-04-25T03:41:23Z

I have written support for this and made a new PR #8185.

cemo · 2020-05-09T16:28:23Z

Any workaround for this?

strkkk · 2020-05-10T11:53:16Z

@cemo the only workaround for now is to use file filter to avoid processing of such files

…yle#6615)

romani · 2020-08-11T22:21:24Z

fix is merged.

cemo · 2020-08-11T22:23:53Z

@romani can you cut a release soon please?

seralekseenko · 2020-08-25T14:05:07Z

Hello.
If I understand correctly, the "unexpected token" problem in the code block has already been fixed.

But I faced the same problem. I am using "checkstyle-8.35".

CheckStyle plugin in IDEA says that it cannot parse the file.

And in the console displays the following text:

Starting audit...
com.puppycrawl.tools.checkstyle.api.CheckstyleException: Exception was thrown while processing /usr/src/app/src/io/hexlet/xo/controllers/WinnerController.java
at com.puppycrawl.tools.checkstyle.Checker.processFiles(Checker.java:311)
at com.puppycrawl.tools.checkstyle.Checker.process(Checker.java:221)
at com.puppycrawl.tools.checkstyle.Main.runCheckstyle(Main.java:408)
at com.puppycrawl.tools.checkstyle.Main.runCli(Main.java:331)
at com.puppycrawl.tools.checkstyle.Main.execute(Main.java:190)
at com.puppycrawl.tools.checkstyle.Main.main(Main.java:125)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: IllegalStateException occurred while parsing file /usr/src/app/src/io/hexlet/xo/controllers/WinnerController.java.
at com.puppycrawl.tools.checkstyle.JavaParser.parse(JavaParser.java:106)
at com.puppycrawl.tools.checkstyle.TreeWalker.processFiltered(TreeWalker.java:149)
at com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck.process(AbstractFileSetCheck.java:87)
at com.puppycrawl.tools.checkstyle.Checker.processFile(Checker.java:337)
at com.puppycrawl.tools.checkstyle.Checker.processFiles(Checker.java:298)
... 5 more
Caused by: java.lang.IllegalStateException: /usr/src/app/src/io/hexlet/xo/controllers/WinnerController.java:48:26: unexpected token: "X"
at com.puppycrawl.tools.checkstyle.JavaParser$1.reportError(JavaParser.java:94)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.typeDefinition(GeneratedJavaRecognizer.java:413)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.compilationUnit(GeneratedJavaRecognizer.java:202)
at com.puppycrawl.tools.checkstyle.JavaParser.parse(JavaParser.java:100)
... 9 more
Caused by: /usr/src/app/src/io/hexlet/xo/controllers/WinnerController.java:48:26: unexpected token: "X"
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.expression(GeneratedJavaRecognizer.java:5295)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.aCase(GeneratedJavaRecognizer.java:6500)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.casesGroup(GeneratedJavaRecognizer.java:6054)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.traditionalStatement(GeneratedJavaRecognizer.java:5754)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.statement(GeneratedJavaRecognizer.java:4769)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.compoundStatement(GeneratedJavaRecognizer.java:4500)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.traditionalStatement(GeneratedJavaRecognizer.java:5507)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.statement(GeneratedJavaRecognizer.java:4769)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.forStatement(GeneratedJavaRecognizer.java:6037)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.traditionalStatement(GeneratedJavaRecognizer.java:5547)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.statement(GeneratedJavaRecognizer.java:4769)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.compoundStatement(GeneratedJavaRecognizer.java:4500)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.traditionalStatement(GeneratedJavaRecognizer.java:5507)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.statement(GeneratedJavaRecognizer.java:4769)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.forStatement(GeneratedJavaRecognizer.java:6037)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.traditionalStatement(GeneratedJavaRecognizer.java:5547)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.statement(GeneratedJavaRecognizer.java:4769)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.compoundStatement(GeneratedJavaRecognizer.java:4500)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.field(GeneratedJavaRecognizer.java:3122)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.classBlock(GeneratedJavaRecognizer.java:3378)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.classDefinition(GeneratedJavaRecognizer.java:635)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.typeDefinitionInternal(GeneratedJavaRecognizer.java:550)
at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.typeDefinition(GeneratedJavaRecognizer.java:391)
... 11 more
Checkstyle ends with 1 errors.

I found that the standard java 14 "switch" syntax throws this error. Here's this piece of code:

switch (tempFigure) {
    case "X" -> counterX++;
    case "O" -> counterO++;
    default -> {}
}

If I am doing something wrong - tell me where to look for a solution?

nrmancuso · 2020-08-25T14:07:59Z

I am using "checkstyle-8.35".

These changes will be in the 8.36 release.

romani · 2020-08-25T14:12:38Z

we will do release as planned, last weekend of month.

…yle#6615)

rnveach added the antlr label Mar 27, 2019

romani added the approved label Mar 28, 2019

romani added the has bounty issue has some money incentive to fix it, https://www.bountysource.com/teams/checkstyle/issues label Apr 13, 2019

arteam mentioned this issue Apr 14, 2019

Issue #6615: Don't fail on Java 12 switch expressions #6664

Closed

strkkk mentioned this issue Mar 30, 2020

java 14 switch expression syntax is not supported #7992

Closed

strkkk changed the title ~~Fails with Java 12 switch expression~~ Fails with Java 14 switch expression Mar 30, 2020

strkkk mentioned this issue Mar 31, 2020

Errors parsing new Java-14 switch statements/expressions #7940

Closed

octylFractal mentioned this issue Apr 25, 2020

Issue #6615: Add support for Java 14 switch #8185

Closed

octylFractal added a commit to octylFractal/checkstyle that referenced this issue Apr 25, 2020

Issue checkstyle#6615: Add support for Java 14 switch

8d39027

ferozco mentioned this issue Jun 12, 2020

Disable broken rule on switch expressions palantir/gradle-baseline#1413

Merged

calixtus mentioned this issue Jun 16, 2020

Validates the file path of a TexGroup and fixes Texgroup's "Library has been modified by another program" JabRef/jabref#6586

Merged

5 tasks

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 9, 2020

minor: Input for Java 14 switch expression(checkstyle#6615)

a2cc554

nrmancuso mentioned this issue Jul 9, 2020

minor: Input for Java 14 switch expression(#6615) #8427

Merged

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 9, 2020

minor: Input for Java 14 switch expression(checkstyle#6615)

9eac5ee

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 13, 2020

minor: Input for Java 14 switch expression(checkstyle#6615)

a38a23c

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 14, 2020

Issue checkstyle#6615: Add support for Java 14 switch and yield

5921ced

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 14, 2020

minor: Input for Java 14 switch expression(checkstyle#6615)

040ff18

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 14, 2020

Issue checkstyle#6615: Add support for Java 14 switch and yield

9446d5e

nrmancuso mentioned this issue Jul 14, 2020

Issue #6615: Add support for Java 14 switch and yield #8449

Merged

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 14, 2020

Issue checkstyle#6615: Add support for Java 14 switch and yield

78c7001

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Aug 10, 2020

minor: refactor traditionalStatement rule grammar related to (checkst…

6455f8c

…yle#6615)

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Aug 10, 2020

Issue checkstyle#6615: Add support for Java 14 switch and yield

8f1b800

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Aug 10, 2020

minor: reformatting of grammar related to (checkstyle#6615)

6254196

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Aug 10, 2020

minor: refactor traditionalStatement rule grammar related to (checkst…

770b59a

…yle#6615)

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Aug 10, 2020

Issue checkstyle#6615: Add support for Java 14 switch and yield

8893bb8

romani linked a pull request Aug 11, 2020 that will close this issue

Issue #6615: Add support for Java 14 switch and yield #8449

Merged

romani changed the title ~~Fails with Java 14 switch expression~~ Support for Java 14 switch/yield expression Aug 11, 2020

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Aug 11, 2020

Issue checkstyle#6615: Add support for Java 14 switch and yield

4482173

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Aug 11, 2020

Issue checkstyle#6615: Add support for Java 14 switch and yield

ea441e3

romani closed this as completed in #8449 Aug 11, 2020

romani pushed a commit that referenced this issue Aug 11, 2020

minor: reformatting of grammar related to (#6615)

bc459ce

romani pushed a commit that referenced this issue Aug 11, 2020

minor: refactor traditionalStatement rule grammar related to (#6615)

e84eb80

romani pushed a commit that referenced this issue Aug 11, 2020

Issue #6615: Add support for Java 14 switch and yield

5ca67a2

romani added the new feature label Aug 11, 2020

romani added this to the 8.36 milestone Aug 11, 2020

stefan-kolb mentioned this issue Aug 12, 2020

Issues depending on external libraries JabRef/jabref#5226

Open

33 tasks

romani reopened this Aug 12, 2020

romani closed this as completed Aug 12, 2020

shiliyu pushed a commit to shiliyu/checkstyle that referenced this issue Sep 1, 2020

minor: reformatting of grammar related to (checkstyle#6615)

0cd73b8

shiliyu pushed a commit to shiliyu/checkstyle that referenced this issue Sep 1, 2020

minor: refactor traditionalStatement rule grammar related to (checkst…

3852121

…yle#6615)

shiliyu pushed a commit to shiliyu/checkstyle that referenced this issue Sep 1, 2020

Issue checkstyle#6615: Add support for Java 14 switch and yield

6dce4a5

jjmgatjobcase mentioned this issue Feb 17, 2021

Java 14 switch statement that assigns to variable confuses checkstyle identation checks #9302

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for Java 14 switch/yield expression #6615

Support for Java 14 switch/yield expression #6615

krzyk commented Mar 27, 2019 •

edited by romani

Loading

rnveach commented Mar 27, 2019

igorleal commented Apr 2, 2019 •

edited

Loading

romani commented Aug 4, 2019

koppor commented Mar 30, 2020

koppor commented Apr 8, 2020

octylFractal commented Apr 25, 2020

cemo commented May 9, 2020

strkkk commented May 10, 2020

romani commented Aug 11, 2020

cemo commented Aug 11, 2020

seralekseenko commented Aug 25, 2020

nrmancuso commented Aug 25, 2020

romani commented Aug 25, 2020

Support for Java 14 switch/yield expression #6615

Support for Java 14 switch/yield expression #6615

Comments

krzyk commented Mar 27, 2019 • edited by romani Loading

rnveach commented Mar 27, 2019

igorleal commented Apr 2, 2019 • edited Loading

romani commented Aug 4, 2019

koppor commented Mar 30, 2020

koppor commented Apr 8, 2020

octylFractal commented Apr 25, 2020

cemo commented May 9, 2020

strkkk commented May 10, 2020

romani commented Aug 11, 2020

cemo commented Aug 11, 2020

seralekseenko commented Aug 25, 2020

nrmancuso commented Aug 25, 2020

romani commented Aug 25, 2020

krzyk commented Mar 27, 2019 •

edited by romani

Loading

igorleal commented Apr 2, 2019 •

edited

Loading