ref(bot): use exhaustiveness checking via NoReturn type #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NoReturn` is Python's `never` which we can use to help ensure we handle all cases. I tried looking for other places where we could use this, but didn't really find any easy places to add it. Also we need to use `is` when comparing enum variants due to mypy's backwards compatible refinement outlined in: python/mypy#6366
chdsbd
approved these changes
Feb 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoReturnis Python'sneverwhich we can use to help ensure we handleall cases.
I tried looking for other places where we could use this, but didn't
really find any easy places to add it.
Also we need to use
iswhen comparing enum variants due to mypy'sbackwards compatible refinement outlined in: python/mypy#6366