Added explicit key for using unsafe string reader #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous PR, the driver used the unsafe method
getStringFromBytes
for returning strings to the caller in theNext
method.This function was used to prevent memory allocation for strings since it just interprets the underlying byte array as a string and return it.
But without an explicit indication from the caller that we should use this method, we should instead return a new allocated string without all the overhead that reusing the byte array implies into the caller.
This PR address this issue and force the user wich want to use the unsafe function, to declare it in the connection parameters while opening the connection.
This will make the driver safer and will allow for a safer use from all the users.