- corrected GH CI for zipping

- fixed some MS analysis issues on uninit vars
chcg · Sep 19, 2024 · 373a96f · 373a96f
1 parent 2048f49
commit 373a96f
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 20 deletions.
diff --git a/.github/workflows/CI_MS_analysis.yml b/.github/workflows/CI_MS_analysis.yml
@@ -9,8 +9,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        build_configuration: [Release, Debug]
-        build_platform: [x64, Win32, ARM64]
+        build_configuration: [Debug]
+        build_platform: [x64]
 
     steps:
     - name: Checkout repo

diff --git a/.github/workflows/CI_build.yml b/.github/workflows/CI_build.yml
@@ -30,7 +30,7 @@ jobs:
       if: matrix.build_configuration == 'Release'
       run: |
            7z a NppJumpList_${{ steps.tagName.outputs.tag }}_${{ matrix.build_platform }}.zip .\${{ matrix.build_platform }}\${{ matrix.build_configuration }}\NppJumpList.dll
-           7z a NppJumpList_${{ steps.tagName.outputs.tag }}_${{ matrix.build_platform }}.zip .\readme.txt"
+           7z a NppJumpList_${{ steps.tagName.outputs.tag }}_${{ matrix.build_platform }}.zip .\readme.txt
 
 
     - name: Archive artifacts for ${{ matrix.build_platform }}

diff --git a/JumpListFunc.h b/JumpListFunc.h
@@ -28,12 +28,12 @@
 
 struct JPTaskProps
 {
-	UINT msg;
-	WPARAM wParam;
-	LPARAM lParam;
+	UINT msg = 0;
+	WPARAM wParam = 0;
+	LPARAM lParam = 0;
 	std::basic_string<TCHAR> taskName;
 	std::basic_string<TCHAR> iconFilePath;
-	int iconResID;
+	int iconResID = 0;
 };
 
 typedef std::map<std::basic_string<TCHAR>, JPTaskProps> TAvailTasks;

diff --git a/PluginDefinition.cpp b/PluginDefinition.cpp
@@ -33,7 +33,7 @@ SettingsManager *settings;
 
 void pluginInit()
 {
-	TCHAR configPath[MAX_PATH], iniPath[MAX_PATH];
+	TCHAR configPath[MAX_PATH]{}, iniPath[MAX_PATH]{};
 	::SendMessage(nppData._nppHandle, NPPM_GETPLUGINSCONFIGDIR, MAX_PATH, (LPARAM)configPath);
 
 	if (::PathFileExists(configPath) == FALSE)

diff --git a/SettingsManager.cpp b/SettingsManager.cpp
@@ -23,13 +23,6 @@ SettingsManager::SettingsManager(LPCTSTR _iniPath)
 {
 	iniPath = _iniPath;
 
-	// default settings
-	enableJP = true;
-	showDefRecent = false;
-	showTasks = true;
-	showDefFrequent = false;
-	showCustomRecent = true;
-
 	tasks.clear();
 	tasks.push_back(TEXT("newfile"));
 }

diff --git a/SettingsManager.h b/SettingsManager.h
@@ -31,11 +31,12 @@ class SettingsManager
 	bool IniReadBool(LPTSTR, LPTSTR, bool&);
 	bool IniReadString(LPTSTR, LPTSTR, std::basic_string<TCHAR>&);
 public:
-	bool enableJP
-		,showDefRecent
-		,showTasks
-		,showCustomRecent
-		,showDefFrequent;
+	// default settings
+	bool enableJP = true;
+	bool showDefRecent = false;
+	bool showTasks = true;
+	bool showCustomRecent = true;
+	bool showDefFrequent = false;
 
 	std::vector<std::basic_string<TCHAR> > tasks;