Skip to content

Commit

Permalink
Clarify format of build-wheel --python argument (closes #1109)
Browse files Browse the repository at this point in the history
  • Loading branch information
mhsmith committed Mar 11, 2024
1 parent 856b6e8 commit 921c3c3
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
3 changes: 2 additions & 1 deletion server/pypi/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ Run build-wheel from this directory as follows:
Where:

* `X.Y` is the Python version you set up above.
* `ABI` is an [Android ABI](https://developer.android.com/ndk/guides/abis).
* `ABI` is an [Android
ABI](https://chaquo.com/chaquopy/doc/current/android.html#android-abis).
* `PACKAGE` is a subdirectory of `packages` in this directory, or the path to another
directory laid out in the same way (see "adding a package" below).

Expand Down
10 changes: 7 additions & 3 deletions server/pypi/build-wheel.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@
import os
from os.path import abspath, basename, dirname, exists, isdir, join, splitext
from pathlib import Path
import pkg_resources
import re
import shlex
import subprocess
import sys
import tempfile
from textwrap import dedent
import traceback
import warnings

import build
from elftools.elf.elffile import ELFFile
Expand All @@ -26,6 +26,10 @@
import pypi_simple
import yaml

with warnings.catch_warnings():
warnings.simplefilter("ignore", DeprecationWarning)
import pkg_resources


PROGRAM_NAME = splitext(basename(__file__))[0]
PYPI_DIR = abspath(dirname(__file__))
Expand Down Expand Up @@ -201,8 +205,8 @@ def parse_args(self):
help="Android ABI: choices=[%(choices)s]")
ap.add_argument("--api-level", metavar="LEVEL", type=int, default=21,
help="Android API level: default=%(default)s")
ap.add_argument("--python", metavar="X.Y", help="Python version (required for "
"Python packages)"),
ap.add_argument("--python", metavar="X.Y", help="Python major.minor version "
"(required for Python packages)"),
ap.add_argument("package", help=f"Name of a package in {RECIPES_DIR}, or if it "
f"contains a slash, path to a recipe directory")
ap.parse_args(namespace=self)
Expand Down
1 change: 1 addition & 0 deletions server/pypi/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ jsonschema==2.6.0
pyelftools==0.29
pypi-simple==1.1.0
PyYAML==6.0
setuptools==69.1.1
tqdm==4.66.1
wheel==0.33.6

Expand Down

0 comments on commit 921c3c3

Please sign in to comment.