fix: device name always eth0 in iptable network attack partition #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some scenarios, eth0 does not exist, but eno1 set through network attack cannot be set in Iptables and it been changed to eth0. Signed-off-by: yuri.yin <yincc8@chinatelecom.cn>
yuriscott
force-pushed
the
fix-network-attack-device-nofound
branch
from
9d9e90c
to
c997f3a
Compare
g1eny0ung
changed the title
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
g1eny0ung
approved these changes
Mar 10, 2024
There was a problem hiding this comment.
Hi @yuriscott, sorry for the late reply. I saw this PR in the Slack channel because someone mentioned it. It's LGTM.
But I would like to know if you have tested this PR in a real environment? like servers or local development environments. I will merge this PR within 1 day as I want to test it as well.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: g1eny0ung The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios, eth0 does not exist, but eno1 set through network attack partition will been replaced eth0 in Iptables.