Store iptables when creating network attack

[FingerLeader]

Signed-off-by: root root@localhost.localdomain
Close #213

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[cwen0]

@FingerLeader I test this pr on my environment, I found the network delay still cancel when I applied a partition action.

./bin/chaosd version
Chaosd Version: version.Info{GitVersion:"fix-partition-g83eccfacc55fe7", GitCommit:"83eccfacc55fe7a29c102df7cb05daa2ea1ac00f", BuildDate:"2022-09-13T15:03:27Z", GoVersion:"go1.19", Compiler:"gc", Platform:"linux/amd64"} 
./bin/chaosd attack network delay -i 39.156.66.10 -d eth0 -l 200ms
./bin/chaosd attack network partition -i 140.205.220.96 -d eth0

[FingerLeader]

I found the network delay still cancel when I applied a partition action.

./bin/chaosd version

I test it again and find it works. Maybe you can delete ./bin/chaosd.dat and try again.

[cwen0]

I found the network delay still cancel when I applied a partition action.

./bin/chaosd version

I test it again and find it works. Maybe you can delete ./bin/chaosd.dat and try again.

OK, I will test it again

[FingerLeader]

@cwen0 I have updated, please have a try again.

[cwen0]

We can delete NeedApplyIptables() and NeedApplyIPSet directly.

[FingerLeader]

I think leaving them can make the code logic clearly, and they may be needed to add features later (by the way, NeedApplyIPSet() is working now)

[cwen0]

I think the logic will be clearer If we delete them. The logic: Chaos Mesh will reset all network action when you apply the network actions. This logic will be more simple.

[FingerLeader]

OK, I think it's OK to be the same as chaos mesh, NeedApplyIptables can be deleted, but I find chaosd attack network delay -l 1s -d eth0 will not work without NeedApplyIPSet()

[cwen0]

We should update this comment.

[FingerLeader]

I don't think this comment should be updated, the filter iptables still not be stored in the DB

[cwen0]

Yes, but here we recover all because chaos mesh will apply all network actions when we apply a new one.

[FingerLeader]

I agree

[cwen0]

LGTM

[cwen0]

/merge

[ti-chi-bot]

@cwen0: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.