Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: gitVersion is invalid when executing chaosd version #205

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented Aug 16, 2022

Signed-off-by: Cwen Yin cwenyin0@gmail.com

chaosd verson:

Chaosd Version: version.Info{GitVersion:"v0.0.0-master+$Format:%h$", GitCommit:"$Format:%H$", BuildDate:"2022-08-15T02:38:21Z", GoVersion:"go1.18.2", Compiler:"gc", Platform:"linux/amd64"} 

Fixed:

GO15VENDOREXPERIMENT="1" CGO_ENABLED=1 GOOS="" GOARCH="" go build -ldflags '-s -w -X 'github.com/chaos-mesh/chaosd/pkg/version.buildDate=2022-08-16T04:01:22Z' -X 'github.com/chaos-mesh/chaosd/pkg/version.gitCommit=b3d667362954aae0213e86e86a553f54a4b1c339' -X 'github.com/chaos-mesh/chaosd/pkg/version.gitVersion=fix-git-version-gb3d667362954aa'' -tags "" -o bin/chaosd ./cmd/main.go

Signed-off-by: Cwen Yin <cwenyin0@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Andrewmatilde
  • g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member Author

cwen0 commented Aug 16, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5ea9e98

@ti-chi-bot ti-chi-bot merged commit 2c42950 into chaos-mesh:main Aug 16, 2022
@cwen0 cwen0 deleted the fix-git-version branch August 16, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants