Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typed config reducer #424

Merged
merged 5 commits into from
Aug 29, 2022
Merged

chore: typed config reducer #424

merged 5 commits into from
Aug 29, 2022

Conversation

atarashansky
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #424 (5b25bbf) into main (eeab220) will not change coverage.
The diff coverage is n/a.

❗ Current head 5b25bbf differs from pull request most recent head 4df0ebb. Consider uploading reports for the commit 4df0ebb to get more accurate results

@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   75.86%   75.86%           
=======================================
  Files          90       90           
  Lines        6778     6778           
=======================================
  Hits         5142     5142           
  Misses       1636     1636           
Flag Coverage Δ
frontend 75.86% <ø> (ø)
javascript 75.86% <ø> (ø)
smokeTest ∅ <ø> (?)
unitTest 75.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

client/src/reducers/config.ts Outdated Show resolved Hide resolved
@atarashansky atarashansky requested a review from seve August 26, 2022 20:24
@atarashansky atarashansky enabled auto-merge (squash) August 29, 2022 18:33
@atarashansky atarashansky merged commit d11f8c6 into main Aug 29, 2022
@atarashansky atarashansky deleted the atar/type-config branch August 29, 2022 18:39
danieljhegeman pushed a commit that referenced this pull request Aug 30, 2022
* chore: updating logo (#389)

* chore: updating logo

* feature: Added loading spinner to geneset average color-by and fixed a continuous legend bug (#384)

* added loading spinner to mean colorby and fixed legend async bug

* revert prettier

* temp fix tsc emit

* typed

* fix

* fixed bugs

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* typed obs crossfilter (#420)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* typed categorical selection reducer (#417)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* typed differential reducer (#419)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* typed annoMatrix reducer (#416)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* chore: purge autosave from codebase (#425)

* chore: typed genesetsUI reducer

* fix tsc error

* chore: purge autosave

* delete nameNewAnnotation

* remove unused

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* chore: typed controls reducer (#418)

* typed controls reducer

* refine scatterplot accessor type to be string or false

* address revisions

* type level return function

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* typed point dilation (#421)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* Revert "feat: add cellxgene schema 3.0.0 fields to Standard Categories (#412)" (#428)

This reverts commit b265fcf.

* typed graph selection reducer (#422)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* chore: typed cascade reducer (#426)

* test

* update cascade reducer

* add map as possible type for cascade

* refactor(cascadeReducer): Quick feedback (#427)

* revert changes

* Update client/src/reducers/cascade.ts

Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>

* remove as string

* refactor(cascadeReducer): Quick feedback 2 (#430)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>
Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com>
Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>

* chore: typed genesetsUI reducer (#423)

* chore: typed genesetsUI reducer

* fix tsc error

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* chore: typed config reducer (#424)

* chore: typed config reducer

* restrict error type

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

Co-authored-by: ashin-czi <109984998+ashin-czi@users.noreply.github.com>
Co-authored-by: atarashansky <atarashansky@chanzuckerberg.com>
Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>
Co-authored-by: Nayib Gloria <55710092+nayib-jose-gloria@users.noreply.github.com>
Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com>
Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>
danieljhegeman pushed a commit that referenced this pull request Sep 1, 2022
* chore: updating logo (#389)

* chore: updating logo

* feature: Added loading spinner to geneset average color-by and fixed a continuous legend bug (#384)

* added loading spinner to mean colorby and fixed legend async bug

* revert prettier

* temp fix tsc emit

* typed

* fix

* fixed bugs

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* typed obs crossfilter (#420)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* typed categorical selection reducer (#417)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* typed differential reducer (#419)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* typed annoMatrix reducer (#416)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* chore: purge autosave from codebase (#425)

* chore: typed genesetsUI reducer

* fix tsc error

* chore: purge autosave

* delete nameNewAnnotation

* remove unused

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* chore: typed controls reducer (#418)

* typed controls reducer

* refine scatterplot accessor type to be string or false

* address revisions

* type level return function

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* typed point dilation (#421)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* Revert "feat: add cellxgene schema 3.0.0 fields to Standard Categories (#412)" (#428)

This reverts commit b265fcf.

* typed graph selection reducer (#422)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* chore: typed cascade reducer (#426)

* test

* update cascade reducer

* add map as possible type for cascade

* refactor(cascadeReducer): Quick feedback (#427)

* revert changes

* Update client/src/reducers/cascade.ts

Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>

* remove as string

* refactor(cascadeReducer): Quick feedback 2 (#430)

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>
Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com>
Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>

* chore: typed genesetsUI reducer (#423)

* chore: typed genesetsUI reducer

* fix tsc error

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

* chore: typed config reducer (#424)

* chore: typed config reducer

* restrict error type

Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>

Co-authored-by: ashin-czi <109984998+ashin-czi@users.noreply.github.com>
Co-authored-by: atarashansky <atarashansky@chanzuckerberg.com>
Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>
Co-authored-by: Nayib Gloria <55710092+nayib-jose-gloria@users.noreply.github.com>
Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com>
Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>

Co-authored-by: ashin-czi <109984998+ashin-czi@users.noreply.github.com>
Co-authored-by: atarashansky <atarashansky@chanzuckerberg.com>
Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local>
Co-authored-by: Nayib Gloria <55710092+nayib-jose-gloria@users.noreply.github.com>
Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com>
Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants