chore: typed genesetsUI reducer #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #423 +/- ##
=======================================
Coverage 75.86% 75.86%
=======================================
Files 90 90
Lines 6778 6778
=======================================
Hits 5142 5142
Misses 1636 1636
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
seve
reviewed
Aug 26, 2022
Comment on lines
+5
to
+6
| isEditingGenesetName: string | false; | ||
| isAddingGenesToGeneset: string | false; |
There was a problem hiding this comment.
This seems overloaded, might be smoke showing that we need to refactor something. Could you look into it really quick and create a ticket if necessary.
There was a problem hiding this comment.
I don't think they're overloaded - They're used for different things
seve
approved these changes
Aug 29, 2022
danieljhegeman
pushed a commit
that referenced
this pull request
Aug 30, 2022
* chore: updating logo (#389) * chore: updating logo * feature: Added loading spinner to geneset average color-by and fixed a continuous legend bug (#384) * added loading spinner to mean colorby and fixed legend async bug * revert prettier * temp fix tsc emit * typed * fix * fixed bugs Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * typed obs crossfilter (#420) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * typed categorical selection reducer (#417) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * typed differential reducer (#419) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * typed annoMatrix reducer (#416) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * chore: purge autosave from codebase (#425) * chore: typed genesetsUI reducer * fix tsc error * chore: purge autosave * delete nameNewAnnotation * remove unused Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * chore: typed controls reducer (#418) * typed controls reducer * refine scatterplot accessor type to be string or false * address revisions * type level return function Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * typed point dilation (#421) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * Revert "feat: add cellxgene schema 3.0.0 fields to Standard Categories (#412)" (#428) This reverts commit b265fcf. * typed graph selection reducer (#422) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * chore: typed cascade reducer (#426) * test * update cascade reducer * add map as possible type for cascade * refactor(cascadeReducer): Quick feedback (#427) * revert changes * Update client/src/reducers/cascade.ts Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com> * remove as string * refactor(cascadeReducer): Quick feedback 2 (#430) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com> * chore: typed genesetsUI reducer (#423) * chore: typed genesetsUI reducer * fix tsc error Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * chore: typed config reducer (#424) * chore: typed config reducer * restrict error type Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> Co-authored-by: ashin-czi <109984998+ashin-czi@users.noreply.github.com> Co-authored-by: atarashansky <atarashansky@chanzuckerberg.com> Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> Co-authored-by: Nayib Gloria <55710092+nayib-jose-gloria@users.noreply.github.com> Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>
danieljhegeman
pushed a commit
that referenced
this pull request
Sep 1, 2022
* chore: updating logo (#389) * chore: updating logo * feature: Added loading spinner to geneset average color-by and fixed a continuous legend bug (#384) * added loading spinner to mean colorby and fixed legend async bug * revert prettier * temp fix tsc emit * typed * fix * fixed bugs Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * typed obs crossfilter (#420) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * typed categorical selection reducer (#417) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * typed differential reducer (#419) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * typed annoMatrix reducer (#416) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * chore: purge autosave from codebase (#425) * chore: typed genesetsUI reducer * fix tsc error * chore: purge autosave * delete nameNewAnnotation * remove unused Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * chore: typed controls reducer (#418) * typed controls reducer * refine scatterplot accessor type to be string or false * address revisions * type level return function Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * typed point dilation (#421) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * Revert "feat: add cellxgene schema 3.0.0 fields to Standard Categories (#412)" (#428) This reverts commit b265fcf. * typed graph selection reducer (#422) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * chore: typed cascade reducer (#426) * test * update cascade reducer * add map as possible type for cascade * refactor(cascadeReducer): Quick feedback (#427) * revert changes * Update client/src/reducers/cascade.ts Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com> * remove as string * refactor(cascadeReducer): Quick feedback 2 (#430) Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com> * chore: typed genesetsUI reducer (#423) * chore: typed genesetsUI reducer * fix tsc error Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> * chore: typed config reducer (#424) * chore: typed config reducer * restrict error type Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> Co-authored-by: ashin-czi <109984998+ashin-czi@users.noreply.github.com> Co-authored-by: atarashansky <atarashansky@chanzuckerberg.com> Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> Co-authored-by: Nayib Gloria <55710092+nayib-jose-gloria@users.noreply.github.com> Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com> Co-authored-by: ashin-czi <109984998+ashin-czi@users.noreply.github.com> Co-authored-by: atarashansky <atarashansky@chanzuckerberg.com> Co-authored-by: atarashansky <atarashansky@CZIMACOS3990.local> Co-authored-by: Nayib Gloria <55710092+nayib-jose-gloria@users.noreply.github.com> Co-authored-by: Timmy Huang <tihuan@users.noreply.github.com> Co-authored-by: Severiano Badajoz <sbadajoz@chanzuckerberg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.