-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ECS ci/cd #251
chore: ECS ci/cd #251
Conversation
Codecov Report
@@ Coverage Diff @@
## main #251 +/- ##
=======================================
Coverage 76.12% 76.12%
=======================================
Files 90 90
Lines 6660 6660
=======================================
Hits 5070 5070
Misses 1590 1590
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
happy_version: "0.17.0" | ||
create-tag: "true" | ||
env: ${{ env.DEPLOYMENT_STAGE }} | ||
# TODO: Uncomment if you want Slack notification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe later, to avoid spamming the channel with noise. Also, will require to add the SLACK_TOKEN
to the secrets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if you remove this code for now (instead of commenting it out) and create a ticket to add slack notifications for portal deployment. You could add the cde on line 62-69 there along with a note about adding the slack token to the secrets for the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I don't think we need this anymore. We have a GH application connected to Slack that can monitor this pipeline for us. I am gonna remove it permanently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if you remove the slack notification code for now (instead of commenting it out) and create a ticket to add slack notifications for portal deployment. You could add the cde on line 62-69 there along with a note about adding the slack token to the secrets for the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Agree w/Madison we should enable or remove slack notification tho.
Reviewers
Functional:
Readability:
Changes