chore: Add newsletter signup to bottom banner (SCE-29) #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaloster
force-pushed
the
kaloster/newsletter-signup
branch
from
9465810
to
8032f93
Compare
kaloster
force-pushed
the
kaloster/newsletter-signup
branch
from
6a0e760
to
ae2edd4
Compare
tihuan
approved these changes
Sep 24, 2024
| @@ -79,4 +79,10 @@ export enum EVENTS { | |||
| DOCUMENTATION_CLICK_NAV = "DOCUMENTATION_CLICK_NAV", | |||
| CELL_GUIDE_CLICK_NAV = "CELL_GUIDE_CLICK_NAV", | |||
| DE_CLICK_NAV = "DE_CLICK_NAV", | |||
|
|
|||
| NEWSLETTER_SIGNUP_SUCCESS = "NEWSLETTER_SIGNUP_SUCCESS", | |||
There was a problem hiding this comment.
I see that you have a reminder to add events to Plausible already 👍 Thanks so much!
kaloster
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1116 +/- ##
=======================================
Coverage 77.60% 77.60%
=======================================
Files 92 92
Lines 7162 7162
=======================================
Hits 5558 5558
Misses 1604 1604
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dynamic-mouse.dev-sc.dev.czi.team/d/super-cool-spatial.cxg/
Added Newsletter Signup modal to bottom banner
Extracted to a child component
Moved hooks and functions to
connectAdded e2e test
Added analytics + plausible
Based on this reverted PR