chore: Add e2e test

chanzuckerberg · Sep 23, 2024 · 8032f93 · 8032f93
1 parent 05c130b
commit 8032f93
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 2 deletions.
diff --git a/.infra/rdev/values.yaml b/.infra/rdev/values.yaml
@@ -2,7 +2,7 @@ stack:
   services:
     explorer:
       image:
-        tag: sha-7d92494d
+        tag: sha-4e15df6f
       replicaCount: 1
       env:
         # env vars common to all deployment stages

diff --git a/client/__tests__/e2e/e2e.test.ts b/client/__tests__/e2e/e2e.test.ts
@@ -236,6 +236,30 @@ for (const testDataset of testDatasets) {
               testInfo
             );
           });
+
+          test("newsletter signup modal opens and closes", async ({ page }) => {
+            await goToPage(page, url);
+
+            await page.getByTestId("newsletter-modal-open-button").click();
+
+            await expect(
+              page.getByTestId("newsletter-modal-content")
+            ).toBeVisible();
+
+            await page.getByTestId("newsletter-email-input").fill("test");
+
+            await page.getByTestId("newsletter-subscribe-button").click();
+
+            await expect(
+              page.getByText("Please provide a valid email address.")
+            ).toBeVisible();
+
+            await page.getByTestId("newsletter-modal-close-button").click();
+
+            await expect(
+              page.getByTestId("newsletter-modal-content")
+            ).not.toBeVisible();
+          });
         });
 
         test("resize graph", async ({ page }, testInfo) => {

diff --git a/client/src/components/BottomBanner/BottomBanner.tsx b/client/src/components/BottomBanner/BottomBanner.tsx
@@ -18,7 +18,7 @@ import {
   BOTTOM_BANNER_NEWSLETTER_TEXT,
   FORM_CONTAINER_ID,
 } from "./constants";
-import { NewsletterSignup } from "./components/NewsletterSignup/NewsletterModal";
+import { NewsletterSignup } from "./components/NewsletterSignup/NewsletterSignup";
 import { useConnect } from "./connect";
 
 export interface BottomBannerProps {

diff --git a/...ents/NewsletterSignup/NewsletterModal.tsx → ...nts/NewsletterSignup/NewsletterSignup.tsx b/...ents/NewsletterSignup/NewsletterModal.tsx → ...nts/NewsletterSignup/NewsletterSignup.tsx