Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore snyk when var not set #216

Merged
merged 3 commits into from
Apr 13, 2019

Conversation

ryanking
Copy link
Contributor

@ryanking ryanking commented Apr 12, 2019

It appears the previous approach doesn't work. I speculate that they don't consider that encrypted env variables are ignored for forks. 🤷‍♂️

@ryanking ryanking requested a review from a team as a code owner April 12, 2019 23:25
@codecov-io
Copy link

Codecov Report

Merging #216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   58.73%   58.73%           
=======================================
  Files          11       11           
  Lines         824      824           
=======================================
  Hits          484      484           
  Misses        267      267           
  Partials       73       73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba1a14...604309e. Read the comment docs.

@ryanking ryanking changed the title [wip] Travis ignore snyk ignore snyk when var not set Apr 12, 2019
Copy link
Contributor

@edulop91 edulop91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@czimergebot czimergebot merged commit bc22276 into chanzuckerberg:master Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants