[feature] generate .travis.yml #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 69.26% 69.35% +0.09%
==========================================
Files 8 10 +2
Lines 693 744 +51
==========================================
+ Hits 480 516 +36
- Misses 129 137 +8
- Partials 84 91 +7
Continue to review full report at Codecov.
|
edulop91
reviewed
Nov 19, 2018
|
|
||
| func (p *Plan) buildTravisCI(c *config.Config) TravisCI { | ||
| if p.Accounts == nil { | ||
| panic("buildTravisCI must be run after buildAccounts") |
There was a problem hiding this comment.
why not return an error instead?
edulop91
approved these changes
Nov 19, 2018
|
@edulop91 good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generate a .travis-ci.yml based on fogg.json.
This introduced a new top-level config in fogg.json for configuring things about travis ci.
When enabled it will use the accounts config to set up profiles and then bucket all the components and modules into a configured number of buckets.