fix: address multiple tomograms feedback #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemonkey800
changed the title
bchu1
reviewed
Oct 21, 2024
frontend/packages/data-portal/app/components/Run/TomogramMetadataDrawer.tsx
Show resolved
Hide resolved
bchu1
approved these changes
Oct 21, 2024
Janeece
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
@codemonkey800 - LGTM! A few of notes, but they are either not blockers or I'm not sure if they should be expected as completed:
- P0 - must have - alignment ID field is missing from Download Single Annotation Step 2 (it was added to step 1)
- P1/P2 - missing Original tomogram field in Annotation info panel
- P2 - nice to have - Tomogram table is still missing max width
- I assumed that Alignment IDs are just placeholder, so any data value inconsistencies weren't noted
codemonkey800
force-pushed
the
jeremy/multiple-tomograms-feedback
branch
from
71d0dd5
to
557d5f8
Compare
github-actions bot
added a commit
that referenced
this pull request
Oct 23, 2024
🤖 I have created a release *beep* *boop* --- ## [1.33.1](web-v1.33.0...web-v1.33.1) (2024-10-23) ### 🐞 Bug Fixes * address multiple tomograms feedback ([#1261](#1261)) ([fce77ad](fce77ad)) * carry over multiple params ([#1252](#1252)) ([3c86411](3c86411)) * view tomogram open in new tab ([#1251](#1251)) ([3312884](3312884)) ### 📝 Documentation * Fix portal links ([#1256](#1256)) ([3a76bcf](3a76bcf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses design feedback from #624 (comment)
Demo
https://dev-on.cryoet.dev.si.czi.technology/