feat: Add annotations and tomograms tables empty states #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchu1
changed the title
Janeece
requested changes
Sep 20, 2024
There was a problem hiding this comment.
thanks @bchu1, this is looking so good!
Here's my comments based on the video:
- Seem to be missing the space between the empty state description and the folder illustrations -- should be space-xxl in between
These two relate to the download run data dialog, so this may not be the right ticket to fix this feedback in:
-
Low priority - In download dialog, can we have the "Download all run data" callout default to open? (seems SDS v2 fixed the bug where it was stuck open, but open is preferred)
-
Maybe a bug - in download dialog, the orange warning dialog shouldn't appear by default unless user has (1) selected "Download tomogram" and (2) selected a non-standard tomogram
Gap added: The other 2 will be done separately |
Janeece
approved these changes
Sep 20, 2024
ehoops-cz
approved these changes
Sep 23, 2024
github-actions bot
added a commit
that referenced
this pull request
Sep 24, 2024
🤖 I have created a release *beep* *boop* --- ## [1.30.0](web-v1.29.0...web-v1.30.0) (2024-09-23) ### ✨ Features * Add alignment ID row + tooltip ([#1153](#1153)) ([1227fbb](1227fbb)) * Add annotations and tomograms tables empty states ([#1155](#1155)) ([bad73bb](bad73bb)) * Add more V2 API fields ([#1166](#1166)) ([0770a16](0770a16)) * Add reference tomogram selector for single annotation download ([#1136](#1136)) ([d1f694a](d1f694a)) * make ML Challenge Page mobile friendly ([#1141](#1141)) ([c25ceeb](c25ceeb)) * Stop querying publications in V2 temporarily ([#1160](#1160)) ([469b9b8](469b9b8)) * Update view tomogram button icons ([#1170](#1170)) ([087d1aa](087d1aa)) * upgrade sds ([#1077](#1077)) ([d56d716](d56d716)) * upgrade sds colors ([#1078](#1078)) ([75ebe8b](75ebe8b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1065
Just the changes to the tables.
Screen.Recording.2024-09-19.at.2.40.29.PM.mov