-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add annotations and tomograms tables empty states #1155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @bchu1, this is looking so good!
Here's my comments based on the video:
- Seem to be missing the space between the empty state description and the folder illustrations -- should be space-xxl in between
These two relate to the download run data dialog, so this may not be the right ticket to fix this feedback in:
-
Low priority - In download dialog, can we have the "Download all run data" callout default to open? (seems SDS v2 fixed the bug where it was stuck open, but open is preferred)
-
Maybe a bug - in download dialog, the orange warning dialog shouldn't appear by default unless user has (1) selected "Download tomogram" and (2) selected a non-standard tomogram
The other 2 will be done separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you @bchu1
🤖 I have created a release *beep* *boop* --- ## [1.30.0](web-v1.29.0...web-v1.30.0) (2024-09-23) ### ✨ Features * Add alignment ID row + tooltip ([#1153](#1153)) ([1227fbb](1227fbb)) * Add annotations and tomograms tables empty states ([#1155](#1155)) ([bad73bb](bad73bb)) * Add more V2 API fields ([#1166](#1166)) ([0770a16](0770a16)) * Add reference tomogram selector for single annotation download ([#1136](#1136)) ([d1f694a](d1f694a)) * make ML Challenge Page mobile friendly ([#1141](#1141)) ([c25ceeb](c25ceeb)) * Stop querying publications in V2 temporarily ([#1160](#1160)) ([469b9b8](469b9b8)) * Update view tomogram button icons ([#1170](#1170)) ([087d1aa](087d1aa)) * upgrade sds ([#1077](#1077)) ([d56d716](d56d716)) * upgrade sds colors ([#1078](#1078)) ([75ebe8b](75ebe8b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
#1065
Just the changes to the tables.
Screen.Recording.2024-09-19.at.2.40.29.PM.mov