Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UPPER function #511

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Add UPPER function #511

merged 6 commits into from
Nov 17, 2023

Conversation

agonist
Copy link
Contributor

@agonist agonist commented Nov 17, 2023

add the UPPER function.

In addition to the upper function, the PR adds a strings definitions package in prevision of adding a bunch of string related functions.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (b034800) 79.06% compared to head (0c13325) 79.03%.

❗ Current head 0c13325 differs from pull request most recent head 2f80922. Consider uploading reports for the commit 2f80922 to get more accurate results

Files Patch % Lines
internal/expr/functions/strings.go 59.09% 16 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   79.06%   79.03%   -0.04%     
==========================================
  Files         125      126       +1     
  Lines       10816    10840      +24     
==========================================
+ Hits         8552     8567      +15     
- Misses       1547     1555       +8     
- Partials      717      718       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asdine asdine merged commit c0397ab into chaisql:main Nov 17, 2023
1 check passed
@asdine asdine added this to the v0.16.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants