Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badgerengine tests on Windows #288

Merged
merged 2 commits into from
Oct 24, 2020
Merged

Conversation

tie
Copy link
Contributor

@tie tie commented Oct 24, 2020

This PR ensures that we close engine before cleanup in enginetest. On Windows tests were failing with the following error.

2020/10/23 21:27:17 remove C:\Users\RUNNER~1\AppData\Local\Temp\genji245175255/badger\000000.vlog: The process cannot access the file because it is being used by another process.
  
  github.com/dgraph-io/badger/v2/y.Wrap
  	github.com/dgraph-io/badger/v2@v2.2007.2/y/error.go:71
  github.com/dgraph-io/badger/v2/y.Check
  	github.com/dgraph-io/badger/v2@v2.2007.2/y/error.go:43
  github.com/dgraph-io/badger/v2.(*valueLog).createVlogFile.func1
  	github.com/dgraph-io/badger/v2@v2.2007.2/value.go:1008
  github.com/dgraph-io/badger/v2.(*valueLog).createVlogFile
  	github.com/dgraph-io/badger/v2@v2.2007.2/value.go:1022
  github.com/dgraph-io/badger/v2.(*valueLog).open
  	github.com/dgraph-io/badger/v2@v2.2007.2/value.go:1120
  github.com/dgraph-io/badger/v2.Open
  	github.com/dgraph-io/badger/v2@v2.2007.2/db.go:396
  github.com/genjidb/genji/engine/badgerengine.NewEngine
  	github.com/genjidb/genji/engine/badgerengine/engine.go:24
  github.com/genjidb/genji/engine/badgerengine_test.builder.func1
  	github.com/genjidb/genji/engine/badgerengine_test/engine_test.go:22
  github.com/genjidb/genji/engine/enginetest.TestStoreNextSequence.func3
  	github.com/genjidb/genji@v0.9.0/engine/enginetest/testing.go:824
  testing.tRunner
  	testing/testing.go:1054
  runtime.goexit
  	runtime/asm_amd64.s:1373

@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #288 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   61.65%   61.65%           
=======================================
  Files          69       69           
  Lines        6496     6496           
=======================================
  Hits         4005     4005           
  Misses       1967     1967           
  Partials      524      524           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c06324d...0d89836. Read the comment docs.

Copy link
Collaborator

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asdine asdine merged commit 16d9a92 into chaisql:master Oct 24, 2020
@tie tie deleted the fix-windows-tests branch October 24, 2020 22:27
@asdine asdine added this to the v0.9.0 milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants