Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table suggestion after FROM keyword #159

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Conversation

tzzed
Copy link
Contributor

@tzzed tzzed commented Aug 21, 2020

This PR fixes the #143 .
Tables are listed after FROM keyword in SELECT and DELETE statements.
Added to DROP TABLE statement too.
If there is no tables the word table_name is displayed:

genji> SELECT * FROM table_name

Copy link
Collaborator

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @tzzed! Just one comment about the error returned, the rest is fine

sql/parser/delete.go Outdated Show resolved Hide resolved
sql/parser/drop.go Outdated Show resolved Hide resolved
sql/parser/select.go Outdated Show resolved Hide resolved
cmd/genji/shell/shell.go Outdated Show resolved Hide resolved
@tzzed tzzed requested a review from asdine August 24, 2020 11:22
Copy link
Collaborator

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@asdine asdine merged commit 8fa24bf into chaisql:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants