Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nginx rewrite for root /vulnerabilities/ url #954

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

jamonation
Copy link
Collaborator

Type of change

bug

What should this PR do?

Rewrites /vulnerabilities/ and /vulnerabilities/index.html with contents of /vuln-comparison/ landing page.

Why are we making this change?

A /vulnerabilities/ page without an ID results in an empty page. Until we have a landing page for vulnerabilities, this redirects to the /vuln-comparison/ landing page.

How should this PR be tested?

Staging URL should show /chainguard/chainguard-images/vuln-comparison/ page when hitting /vulnerabilities/ - netlify won't work since it doesn't use nginx.

@jamonation jamonation requested a review from a team as a code owner August 27, 2023 14:28
@netlify
Copy link

netlify bot commented Aug 27, 2023

Deploy Preview for ornate-narwhal-088216 ready!

Name Link
🔨 Latest commit 2a1397f
🔍 Latest deploy log https://app.netlify.com/sites/ornate-narwhal-088216/deploys/64eb5fe320ec780008e80926
😎 Deploy Preview https://deploy-preview-954--ornate-narwhal-088216.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Jamon Camisso <jamonation+git@gmail.com>
@jamonation jamonation force-pushed the nginx-vulnerabilities-rewrite branch from 295901b to 2a1397f Compare August 27, 2023 14:38
@ltagliaferri ltagliaferri merged commit ea818ae into main Aug 27, 2023
9 checks passed
@mattmoor mattmoor deleted the nginx-vulnerabilities-rewrite branch March 9, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants