Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tool to generate rumble json files for detected vulnerabilities #890

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

jamonation
Copy link
Collaborator

Type of change

platform

What should this PR do?

This adds a github workflow to generate JSON files for each vulnerability that Rumble detects in external images and Chainguard Images.

What are the acceptance criteria?

The Github action for this should run, and files should be publicly accessible in the GCS bucket.

How should this PR be tested?

Run the action

Signed-off-by: Jamon Camisso <jamonation+git@gmail.com>
@jamonation jamonation requested a review from a team as a code owner August 7, 2023 14:46
@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for ornate-narwhal-088216 ready!

Name Link
🔨 Latest commit 2e6fb32
🔍 Latest deploy log https://app.netlify.com/sites/ornate-narwhal-088216/deploys/64d69d4b3c560e000843ce6c
😎 Deploy Preview https://deploy-preview-890--ornate-narwhal-088216.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jamonation jamonation changed the title WIP: Add tool to generate rumble json files for detected vulnerabilities Add tool to generate rumble json files for detected vulnerabilities Aug 11, 2023
@jamonation jamonation self-assigned this Aug 11, 2023
@jamonation
Copy link
Collaborator Author

With a little finessing of IAM ServiceAccount settings courtesy @jspeed-meyers, got this action working! https://github.com/chainguard-dev/edu/actions/runs/5836886137/job/15831360816

So I think it is ready to merge and iterate on e.g. adding tests since it needs them badly.

Copy link
Collaborator

@SharpRake SharpRake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@jamonation jamonation merged commit e78fb6e into main Aug 11, 2023
9 checks passed
@jamonation jamonation deleted the rumble-vulnerability-data branch August 11, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants