Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding oci artifacts draft #334

Merged
merged 8 commits into from
Feb 7, 2023
Merged

Adding oci artifacts draft #334

merged 8 commits into from
Feb 7, 2023

Conversation

sheesh
Copy link
Collaborator

@sheesh sheesh commented Feb 3, 2023

Type of change

What should this PR do?

Why are we making this change?

What are the acceptance criteria?

How should this PR be tested?

@sheesh sheesh added the documentation Improvements or additions to documentation label Feb 3, 2023
@sheesh sheesh requested a review from a team as a code owner February 3, 2023 18:00
@sheesh sheesh self-assigned this Feb 3, 2023
@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for ornate-narwhal-088216 ready!

Name Link
🔨 Latest commit a3cb8d1
🔍 Latest deploy log https://app.netlify.com/sites/ornate-narwhal-088216/deploys/63e19462cf31000008295242
😎 Deploy Preview https://deploy-preview-334--ornate-narwhal-088216.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far! Just a couple small things. I can give it another read later too.

content/open-source/oci/what-are-oci-artifacts.md Outdated Show resolved Hide resolved
content/open-source/oci/what-are-oci-artifacts.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming along great, and thank you @jdolitsky and @imjasonh for the comments and discussions to strengthen this!

@sheesh once you edit / address the comments / suggestions please merge in

content/open-source/oci/what-are-oci-artifacts.md Outdated Show resolved Hide resolved
content/open-source/oci/what-are-oci-artifacts.md Outdated Show resolved Hide resolved
content/open-source/oci/what-are-oci-artifacts.md Outdated Show resolved Hide resolved
content/open-source/oci/what-are-oci-artifacts.md Outdated Show resolved Hide resolved
content/open-source/oci/what-are-oci-artifacts.md Outdated Show resolved Hide resolved
@ltagliaferri ltagliaferri merged commit 4a8a201 into main Feb 7, 2023
@ltagliaferri ltagliaferri deleted the oci-artifacts branch May 11, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants