forked from ava-labs/coreth
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cortina 19: Ava-labs/core-eth v0.12.11-rc.2 (avalanchego 1.10.19) #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove ethdb * fix codebase * merge fixes * missed this file
* add UT for eth tx pool subscribe * fix eth tx pool subscribtion * remove extra registry param * don't use journal * simplify test * increase timeout
Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
* Fix stat emitted for eth txs gossip received error * fix name * Add back atomic error stat
* align types/block.go with addative upstream * align with subnet-evm for now * add copyright header * rename to WithExtData
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
# Conflicts: # .github/workflows/ci.yml # RELEASES.md # core/genesis.go # go.sum # params/config.go # plugin/evm/version.go # scripts/build_test.sh # scripts/versions.sh
knikos
force-pushed
the
nikos/cortina/19
branch
2 times, most recently
from
March 28, 2024 11:43
d0d08c8
to
6faed94
Compare
knikos
force-pushed
the
nikos/cortina/19
branch
from
March 28, 2024 11:54
6faed94
to
6309f4f
Compare
evlekht
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR contains changes from ava-labs/core-eth between cortina-18 and cortina-19. Its required for upcoming merge of cortina-19 changes to caminogo.
Notable changes
Diff with previous tag
v1.1.18-rc0
(coreth v0.12.10-rc.5) ava-labs/coreth@v0.12.10-rc.5...v0.12.11-rc.2How this works
Conflicts
ci
: Add shellcheck step to lint job ava-labs/coreth#464)$@ -> "$@"
probably due to linter introduction)Fixes
Minor sh scripts changes due to newly introduced linter
namely adding quotes due to warnings or restructuring slightly to satisfy linter
How this was tested
ci