Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use avalanchego upgrade times #466

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Use avalanchego upgrade times #466

merged 2 commits into from
Jan 23, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

  1. Hardcoding the same timestamp twice is error prone and annoying.
  2. This allows easier fork testing because only the avalanchego timestamps need to be modified to test upgrades locally

How this works

  • Depends on avalanchego's version package for timestamps.
  • This does change the timestamp for Durango from nil to the year 10000. This should be safe because modifications of the fork times are safe as long as the fork hasn't been activated on chain yet.

How this was tested

  • Existing CI

@StephenButtolph StephenButtolph self-assigned this Jan 23, 2024
@darioush darioush enabled auto-merge (squash) January 23, 2024 19:31
@darioush darioush merged commit 4d14203 into master Jan 23, 2024
8 checks passed
@darioush darioush deleted the use-avalanchego-upgrade-times branch January 23, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darioush darioush darioush approved these changes

@ceyonur ceyonur ceyonur approved these changes

@aaronbuchwald aaronbuchwald Awaiting requested review from aaronbuchwald

Assignees

@StephenButtolph StephenButtolph

Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenButtolph @darioush @ceyonur