Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configures redirectTo to accept regex #243

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Conversation

mikemfleming
Copy link

In reference to #235

lib/http.js Outdated Show resolved Hide resolved
@austince
Copy link
Contributor

Also, just want to say thanks for the PR and looks good!

@mikemfleming
Copy link
Author

No problem! Happy to help 😎

@austince
Copy link
Contributor

👍 Would you mind also updating the signature in the Readme?

Copy link
Contributor

@austince austince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! Let's see what others have to say

lib/http.js Outdated Show resolved Hide resolved
@austince

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants