Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageNav never unlocks when Page is _isOptional #64

Closed
StuartNicholls opened this issue May 1, 2024 · 1 comment · Fixed by #65
Closed

PageNav never unlocks when Page is _isOptional #64

StuartNicholls opened this issue May 1, 2024 · 1 comment · Fixed by #65
Assignees
@StuartNicholls
Labels
bug Something isn't working released

Comments

@StuartNicholls
Copy link
Contributor

Subject of the issue

When the page is set as optional (a use case would be via something like the diagnostic plug-in) and PageNav is set to, _lockUntilPageComplete, PageNav remains locked - even after completing the topic.

Steps to reproduce

Install the diagnostic plug-in or set the page to isoptuional in the JSON

Expected behaviour

The page would automatically unlock if the page is set to isOptional if _lockUntilPageComplete is set to true.

Actual behaviour

Locked button never unlocks
@StuartNicholls StuartNicholls mentioned this issue May 1, 2024
Merged
@guywillis guywillis added the bug Something isn't working label May 1, 2024
oliverfoster added a commit that referenced this issue May 1, 2024
@oliverfoster
Fix: Check if content object(page) is set to _isOptional and unlock p…
3647bf7 
…ageNav button if set to _lockUntilPageComplete (fixes #64)
github-actions bot pushed a commit that referenced this issue May 1, 2024
@semantic-release-bot
Chore(release): 3.1.3 [skip ci]
e9cce27 
## [3.1.3](v3.1.2...v3.1.3) (2024-05-01)

### Fix

* Check if content object(page) is set to _isOptional and unlock pageNav button if set to _lockUntilPageComplete (fixes #64) ([3647bf7](3647bf7)), closes [#64](#64)
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

🎉 This issue has been resolved in version 3.1.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StuartNicholls StuartNicholls

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
2 participants
@StuartNicholls @guywillis