Framework: _loopStyle must be explicitly set

[swashbuck]

Subject of the issue

The README.md states that _loopStyle defaults to 'none'. In fact, if it's not set, it does not default to anything and the next/previous buttons are not shown at all. I would suggest that we default _loopStyle to 'none' if not set in the JSON.

adapt-pageNav/js/PageNavModel.js

Line 145 in 62dab8c

if (!loopStyle) return [];

Also, the siblings option has recently been removed from the plugin. This should be removed from example.json and README.md for _loopStyleComment.

Your environment

• Version: Framework (not AAT)
• Page Nav: 3.1.1

Steps to reproduce

In a framework project (not AAT):

1. In the standard p101 that has a co-100 and co-200, add a Page Nav component to the first (co-100) topic.
2. Enable the _root and _next buttons.
3. Set _loopStyle to 'none' which should be the default.
4. Observe that the Next button is visible
5. Now, remove the _loopStyle line entirely from the Page Nav component config.
6. Observe that only the Main Menu button remains.

[oliverfoster]

These lines should not have been removed:

7c8d863#diff-6c2ae9233aadf60cb19e106cb2fdffa44f13ef7e5d14e95b1ff2e666f791ae78L179-L181

Siblings buttons and siblings looping are different behaviours with the same subject.

[github-actions]

🎉 This issue has been resolved in version 3.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀