Duplicate aria-label

[zubairslamdien]

Aria label needs removing from template

The aria-label on the button container should be removed because it already gets one from the core ariaRegion div.

Screenshots (if you can)

[oliverfoster]

You could do it the other way round?

<nav></nav> is equivalent to <div role="navigation"></div>

Role navigation is a landmark role, so you'd be able to jump to it with accessibility shortcuts.

It makes sense that the nav tag has a label.

The top aria label can come from either here and here for handlebars or here for jsx. You can see that those functions are controlled with the model attribute _isA11yComponentDescriptionEnabled which defaults to true in componentModel.

Probably best to force the pageNav model to default to false for _isA11yComponentDescriptionEnabled instead of removing from the nav element?

[github-actions]

🎉 This issue has been resolved in version 3.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀