Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Commit

Permalink
fix variable redefinition error, add missing semi-colons, proper path…
Browse files Browse the repository at this point in the history
… definitions
  • Loading branch information
moloko committed Jan 8, 2019
1 parent d03b73d commit 1743ecc
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 16 deletions.
10 changes: 5 additions & 5 deletions js/adapt-nudge.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
define([
'coreJS/adapt',
'coreModels/componentModel',
'core/js/adapt',
'core/js/models/componentModel',
'./pageNudge',
'./trickleNudge'
], function(Adapt, ComponentModel) {
Expand Down Expand Up @@ -95,7 +95,7 @@ define([

model.set({
'_nudge':_.extend({}, defaults, cfg),
'_isNudgeConfigured':true
'_isNudgeConfigured': true
});

return model.get('_nudge');
Expand All @@ -116,7 +116,7 @@ define([

require('extensions/adapt-contrib-spoor/js/serializers/scormSuspendDataSerializer');

var data = SCORMSuspendData.deserialize(data);
data = SCORMSuspendData.deserialize(data);
var i = 0;

cfg._hasUserGotScroll = data[i++];
Expand Down Expand Up @@ -157,7 +157,7 @@ define([
cfg = this.getConfig(co);
data.push(cfg._isScrollEnabled, cfg._isPlpEnabled, cfg._isTrickleEnabled, cfg._isPageCompletionEnabled);
}, this);

return data;
},

Expand Down
12 changes: 6 additions & 6 deletions js/pageNudge.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
define([
'coreJS/adapt',
'core/js/adapt',
'./pageNudgeView',
'./enums/nudgeStateEnum'
], function(Adapt, PageNudgeView, NUDGE_STATE) {
Expand Down Expand Up @@ -164,7 +164,7 @@ define([
}
});
var ret = {'onscreen':onscreen, 'offscreen':offscreen};

return ret;
},

Expand All @@ -180,7 +180,7 @@ define([
var plpModeDisabled = !courseConfig._isPlpEnabled || !pageConfig._isPlpEnabled;
var nudgePlpBeforeScroll = courseConfig._nudgePlpBeforeScroll;
var pageCompletionDisabled = !courseConfig._isPageCompletionEnabled || !pageConfig._isPageCompletionEnabled;

switch (this._mode) {
case NUDGE_STATE.COMPLETE:
if (Adapt.nudge.debug) console.log('_changeMode: mode=complete, calling finish');
Expand Down Expand Up @@ -256,8 +256,8 @@ define([
},

logComponentVisibilityState:function(state) {
console.log('onscreen:', _.map(state.onscreen, function(s){return s.component.get('_id')}).join(','));
console.log('offscreen:', _.map(state.offscreen, function(s){return s.component.get('_id')}).join(','));
console.log('onscreen:', _.map(state.onscreen, function(s){return s.component.get('_id');}).join(','));
console.log('offscreen:', _.map(state.offscreen, function(s){return s.component.get('_id');}).join(','));
},

onScroll:function() {
Expand Down Expand Up @@ -353,7 +353,7 @@ define([
else if (this._mode == NUDGE_STATE.COMPLETE) courseConfig._hasUserGotPageCompletion = true;

Adapt.nudge.saveState();

this._changeMode();
},

Expand Down
2 changes: 1 addition & 1 deletion js/pageNudgeView.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
define([
'coreJS/adapt',
'core/js/adapt',
'./enums/nudgeStateEnum'
], function(Adapt, NUDGE_STATE) {

Expand Down
2 changes: 1 addition & 1 deletion js/trickleNudge.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
define([
'coreJS/adapt',
'core/js/adapt',
'./trickleNudgeView'
], function(Adapt, TrickleNudgeView) {

Expand Down
6 changes: 3 additions & 3 deletions js/trickleNudgeView.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
define([
'coreJS/adapt'
'core/js/adapt'
], function(Adapt) {

var TrickleNudgeView = Backbone.View.extend({
Expand Down Expand Up @@ -40,8 +40,8 @@ define([
if (this.state._isVisible == visible) return;

this.state._isVisible = visible;
this.$el.toggleClass('display-none', !visible)
this.$el.toggleClass('display-none', !visible);

if (visible) {
this.$el.css('bottom', $('.trickle-button-inner', this.state._$trickleComponent).outerHeight());
}
Expand Down

0 comments on commit 1743ecc

Please sign in to comment.