Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: set item Title as required in component schema (fixes #146) #148

Merged
merged 2 commits into from
May 7, 2024
Merged

Update: set item Title as required in component schema (fixes #146) #148

merged 2 commits into from
May 7, 2024

Conversation

kirsty-hames
Copy link
Contributor

@kirsty-hames kirsty-hames commented Mar 7, 2024 •
edited
Loading

This should have been implemented as part of merged PR - Title is required to set notify popup dialog label for consistency with Hotgraphic PR. Branch re-opened.

Fixes #146

@kirsty-hames kirsty-hames self-assigned this Mar 7, 2024
guywillis
guywillis approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@kirsty-hames kirsty-hames merged commit 3f71514 into master May 7, 2024
1 check passed
@kirsty-hames kirsty-hames deleted the issue/146 branch May 7, 2024 09:16
github-actions bot pushed a commit that referenced this pull request May 7, 2024
@semantic-release-bot
Chore(release): 4.6.0 [skip ci]
6ba1542 
# [4.6.0](v4.5.3...v4.6.0) (2024-05-07)

### Update

* set item Title as required in component schema (fixes #146) (#148) ([3f71514](3f71514)), closes [#146](#146) [#148](#148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guywillis guywillis guywillis approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Title is required to set notify popup dialog label
2 participants
@kirsty-hames @guywillis