Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme styles can bleed into Course Map #75

Closed
swashbuck opened this issue Oct 10, 2023 · 1 comment · Fixed by #79
Closed

Theme styles can bleed into Course Map #75

swashbuck opened this issue Oct 10, 2023 · 1 comment · Fixed by #79
Assignees
@swashbuck
Labels
bug released

Comments

@swashbuck
Copy link
Contributor

Subject of the issue

Theme styles can bleed into the Course Map if they're used in the display title. For example, this displayTitle contains <span> tags with theme classes, and those carry over into the Course Map.

"displayTitle": "Welcome to <span class='splash-title__course-name'>Client<i>Name's</i><sup>&trade;</sup> Training</span>",
Screenshot 2023-10-10 at 10 50 46 AM
@swashbuck swashbuck added the bug label Oct 10, 2023
@swashbuck swashbuck self-assigned this Feb 16, 2024
@swashbuck swashbuck mentioned this issue Feb 16, 2024
Merged
swashbuck added a commit that referenced this issue Mar 4, 2024
@swashbuck @oliverfoster
Fix: Strip HTML tags from title (fixes #75)
a28e773 
Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
github-actions bot pushed a commit that referenced this issue Mar 4, 2024
@semantic-release-bot
Chore(release): 3.3.1 [skip ci]
67d61e0 
## [3.3.1](v3.3.0...v3.3.1) (2024-03-04)

### Fix

* Strip HTML tags from title (fixes #75) ([a28e773](a28e773)), closes [#75](#75)
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

🎉 This issue has been resolved in version 3.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Strip HTML tags from title (fixes #75) cgkineo/adapt-devtools
1 participant
@swashbuck