Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation button: Add support for data-order #61

Closed
swashbuck opened this issue Oct 3, 2022 · 1 comment · Fixed by #80
Closed

Navigation button: Add support for data-order #61

swashbuck opened this issue Oct 3, 2022 · 1 comment · Fixed by #80
Assignees
@kirsty-hames
Labels
enhancement

Comments

@swashbuck
Copy link
Contributor

Support for the data-order attribute was added to the navigation here. However, this is not yet supported in Dev Tools. Furthermore, it seems that manually adding something like data-order=10000 has no effect on the order of the button.
@swashbuck
Copy link
Contributor Author

I believe the navigation button is currently meant to always be the last button? So, this would probably need amended in addition to adding the actual data-order value.

adapt-devtools/js/adapt-devtools.js

Line 393 in 0cd68c8

// keep drawer item to left of PLP, resources, close button etc

@kirsty-hames kirsty-hames self-assigned this Mar 13, 2024
@kirsty-hames kirsty-hames mentioned this issue Mar 13, 2024
Merged
kirsty-hames added a commit that referenced this issue Mar 13, 2024
@kirsty-hames
Update: add data-order to nav button (#61) (#80)
12d70d6 
* hard code nav btn data-order

* remove redundant comment regarding nav btn rendering position

* remove legacy nav btn float
github-actions bot pushed a commit that referenced this issue Mar 13, 2024
@semantic-release-bot
Chore(release): 3.4.0 [skip ci]
4a6152c 
# [3.4.0](v3.3.1...v3.4.0) (2024-03-13)

### Update

* add data-order to nav button (#61) (#80) ([12d70d6](12d70d6)), closes [#61](#61) [#80](#80)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: add data-order to nav button (#61) cgkineo/adapt-devtools
2 participants
@swashbuck @kirsty-hames