Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser prompt: spoor will finish the LMS session even if the learner clicks 'stay on page' #10

Closed
moloko opened this issue Mar 1, 2019 · 0 comments · Fixed by #12
Closed

Browser prompt: spoor will finish the LMS session even if the learner clicks 'stay on page' #10

moloko opened this issue Mar 1, 2019 · 0 comments · Fixed by #12
Assignees
@moloko

Comments

@moloko
Copy link
Contributor

moloko commented Mar 1, 2019 •
edited
Loading

When either/both browserPromptIfIncomplete/browserPromptIfComplete config options are set: because the spoor plugin also handles the beforeunload event, it will trigger its SCOFinish routine which terminates the SCORM 'session'. So if the learner selects 'stay on page' in the browser prompt the course will stay open but won't be able to track.
@moloko moloko self-assigned this Mar 1, 2019
moloko added a commit that referenced this issue Mar 1, 2019
@moloko
stop spoor from handling beforeunload if either browser prompt settin…
38c2417 
…g is enabled (fixes #10)
@moloko moloko mentioned this issue Mar 1, 2019
Merged
moloko added a commit that referenced this issue Mar 28, 2019
@moloko
stop spoor from handling beforeunload if either browser prompt settin…
c66ec8b 
…g is enabled (fixes #10) (#12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moloko moloko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stop spoor from handling beforeunload cgkineo/adapt-close
1 participant
@moloko