Fix: Update navigation height less variable to css variable.

[StuartNicholls]

Update to less variable with adapt css variable.

Fixes: #49

[guywillis]

👀

[swashbuck]

@StuartNicholls Should probably mention the required core/framework version? https://github.com/adaptlearning/adapt-contrib-core/releases/tag/v6.34.0

bower.json, package.json, and maybe add it to the readme.

[StuartNicholls]

@StuartNicholls Should probably mention the required core/framework version? https://github.com/adaptlearning/adapt-contrib-core/releases/tag/v6.34.0

bower.json, package.json, and maybe add it to the readme.

Thats a very good point, didn't consider that as was operating in CG Kineo.

Re. bower.json, I think we just need to add the framework number to package.json though. @guywillis is that correct?

@swashbuck is that the correct version? Also, we should probably fix that here: https://github.com/adaptlearning/adapt-contrib-trickle/blob/bef0310950855ed0fde4f17835942e19cb73d5e8/package.json#L4 - and anywhere this might have been updated?

[StuartNicholls]

Actually, @swashbuck - I'm not sure about this as in theory it still works to a degree as the less variable is still available. @guywillis what do you think? (Edit: @swashbuck ignore this!)

[guywillis]

Re. bower.json, I think we just need to add the framework number to package.json though. @guywillis is that correct?

Yeah, we will need to bump the framework version in both the bower.json and package.json

Actually, @swashbuck - I'm not sure about this as in theory it still works to a degree as the less variable is still available. @guywillis what do you think?

This plugin will need the framework upping to at least v6.34.0 as this release contains the first instance of the --adapt-navigation-height css variable in core.

[oliverfoster]

adapt-backgroundSwitcher/package.json

Line 32 in 7252c9e

"postversion": "cp package.json bower.json"

Part of the release process copies the package.json over the top if the bower JSON. You only need to update the fw version in the package.json as long as you follow the release cycle the bower.json will be updated automatically.

[swashbuck]

is that the correct version? Also, we should probably fix that here: https://github.com/adaptlearning/adapt-contrib-trickle/blob/bef0310950855ed0fde4f17835942e19cb73d5e8/package.json#L4 - and anywhere this might have been updated?

@StuartNicholls Yes, agreed that other plugins will need the framework version updated.

What I'm not sure about is how we specify the requirement. The Framework tags aren't the same as the Core plugin tags. We only specify the required Framework version in package.json:

  "framework": ">=5.8",

[swashbuck]

👍

[kirsty-hames]

What I'm not sure about is how we specify the requirement. The Framework tags aren't the same as the Core plugin tags. We only specify the required Framework version in package.json:

Did anyone confirm this as I'm not sure about this myself so would be good to know? I currently download the core release and check the FW version in the package.json.

In which case, shouldn't this have a minimum FW requirement of v5.20.2? I'm not sure where v5.30.3 came from.

[guywillis]

What I'm not sure about is how we specify the requirement. The Framework tags aren't the same as the Core plugin tags. We only specify the required Framework version in package.json:

Did anyone confirm this as I'm not sure about this myself so would be good to know? I currently download the core release and check the FW version in the package.json.

In which case, shouldn't this have a minimum FW requirement of v5.20.2? I'm not sure where v5.30.3 came from.

I doubt this is the optimal way of finding out but this was my process:

• This PR adds the var(--adapt-navigation-height) css variable
• I searched where this variable first appears in core which is 6.34.0
• The corresponding framework release that is the same date as the core release was 5.30.3

[StuartNicholls]

What I'm not sure about is how we specify the requirement. The Framework tags aren't the same as the Core plugin tags. We only specify the required Framework version in package.json:

Did anyone confirm this as I'm not sure about this myself so would be good to know? I currently download the core release and check the FW version in the package.json.
In which case, shouldn't this have a minimum FW requirement of v5.20.2? I'm not sure where v5.30.3 came from.

I doubt this is the optimal way of finding out but this was my process:

• This PR adds the var(--adapt-navigation-height) css variable
• I searched where this variable first appears in core which is 6.34.0
• The corresponding framework release that is the same date as the core release was 5.30.3

This is exactly what I do

[github-actions]

🎉 This PR is included in version 5.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀