-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new threading-aware canvas class #327
Conversation
…ponentManager (so this doesn't need to be duplicated by all viewer implementations)
…ure (de-)initialization etc. are called from the right thread
…tion logic for that
…to canvas_refactor
Please test this on all platforms and give feedback to the new rendering and mainloop implementations |
Works on macOS |
Works on Windows |
…d rapid redraw, e.g. during resize of the window
Last call for feedback on this PR :) |
From what I can see, the new |
Right after startup the following error appears exactly 6 times on cerr: It seems that GL_RED_BITS through GL_STENCIL_BITS are not part of the OpenGL 4.5 specification anymore (see lists in 4.5 glGet reference and 2.1 glGet reference) Yet I haven't noticed any negative impact whatsoever though, but I also don't know, where these values are required at the moment. Neither do I know, why the very same code on the master branch runs without generating the error messages. |
Thanks for reporting that. Please make a separate issue, we should investigate it further. |
Lets refactor the canvas and mainloop here. It should be clearly designed and documented what methods and signals are to be used from what thread (UI thread or render thread) to make the new canvas class work on multithreaded viewers such as QtQuick.