Skip to content

Commit

Permalink
Enable reftypes tests on aarch64.
Browse files Browse the repository at this point in the history
With bytecodealliance#1852, we now have support for reference types in the new backend
framework generally, and on aarch64 in particular. This PR removes the
test-ignore directive for reftypes tests on this platform.

Closes bytecodealliance#1886.
  • Loading branch information
cfallin committed Jul 15, 2020
1 parent c3e8a04 commit ac5130c
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 20 deletions.
6 changes: 0 additions & 6 deletions build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,6 @@ fn ignore(testsuite: &str, testname: &str, strategy: &str) -> bool {
// to be a big chunk of work to implement them all there!
("simd", _) if target.contains("aarch64") => return true,

// TODO(#1886): Ignore reference types tests if this isn't x64,
// because Cranelift only supports reference types on x64.
("reference_types", _) => {
return env::var("CARGO_CFG_TARGET_ARCH").unwrap() != "x86_64";
}

_ => {}
},
_ => panic!("unrecognized strategy"),
Expand Down
9 changes: 0 additions & 9 deletions tests/all/func.rs
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,6 @@ fn signatures_match() {
}

#[test]
// Note: Cranelift only supports refrerence types (used in the wasm in this
// test) on x64.
#[cfg(target_arch = "x86_64")]
fn import_works() -> Result<()> {
static HITS: AtomicUsize = AtomicUsize::new(0);

Expand Down Expand Up @@ -444,9 +441,6 @@ fn func_write_nothing() -> anyhow::Result<()> {
}

#[test]
// Note: Cranelift only supports refrerence types (used in the wasm in this
// test) on x64.
#[cfg(target_arch = "x86_64")]
fn return_cross_store_value() -> anyhow::Result<()> {
let wasm = wat::parse_str(
r#"
Expand Down Expand Up @@ -479,9 +473,6 @@ fn return_cross_store_value() -> anyhow::Result<()> {
}

#[test]
// Note: Cranelift only supports refrerence types (used in the wasm in this
// test) on x64.
#[cfg(target_arch = "x86_64")]
fn pass_cross_store_arg() -> anyhow::Result<()> {
let mut config = Config::new();
config.wasm_reference_types(true);
Expand Down
5 changes: 0 additions & 5 deletions tests/all/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,9 @@ mod traps;
mod use_after_drop;
mod wast;

// TODO(#1886): Cranelift only supports reference types on x64.
#[cfg(target_arch = "x86_64")]
mod funcref;
#[cfg(target_arch = "x86_64")]
mod gc;

/// A helper to compile a module in a new store with reference types enabled.
#[cfg(target_arch = "x86_64")]
pub(crate) fn ref_types_module(
source: &str,
) -> anyhow::Result<(wasmtime::Store, wasmtime::Module)> {
Expand Down

0 comments on commit ac5130c

Please sign in to comment.