Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orchestra: Respect username if set in ssh config #2000

Merged
merged 1 commit into from
Aug 20, 2024
Merged

orchestra: Respect username if set in ssh config #2000

merged 1 commit into from
Aug 20, 2024

Conversation

zmc
Copy link
Member

@zmc zmc commented Aug 20, 2024

No description provided.

@zmc
orchestra: Respect username if set in ssh config
ce2f484 
Signed-off-by: Zack Cerza <zack@redhat.com>
dmick
dmick approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good compromise to me. I've added code to the sepia-fog-builder job to verify this configuration and error out if not there.

@dmick dmick marked this pull request as ready for review August 20, 2024 23:51
@dmick dmick merged commit 4d4c5e3 into main Aug 20, 2024
9 checks passed
@zmc zmc deleted the user branch August 22, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmick dmick dmick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmc @dmick