Revert "orchestra/daemon/cephadmunit.py: fix method kill_cmd()" #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2c6d64a. Related tracker: https://tracker.ceph.com/issues/66883
VallariAg
approved these changes
Aug 14, 2024
|
Teuthology tests scheduled with the commit reverted: https://pulpito.ceph.com/lflores-2024-08-06_19:53:18-rados:thrash-old-clients-main-distro-default-smithi/ |
Thanks! I'm open to evaluating the kill command again and improving it if needed. But this is just to unblock the 19.1.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2c6d64a.
Related tracker: https://tracker.ceph.com/issues/66883
See the tracker for analysis on how this commit causes unintended behavior in teuthology tests that involve thrashing.